Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253AbaJ1KRi (ORCPT ); Tue, 28 Oct 2014 06:17:38 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:57635 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753111AbaJ1KRg (ORCPT ); Tue, 28 Oct 2014 06:17:36 -0400 MIME-Version: 1.0 In-Reply-To: <1413309277-32485-1-git-send-email-david.a.cohen@linux.intel.com> References: <1413224639-21552-1-git-send-email-david.a.cohen@linux.intel.com> <1413309277-32485-1-git-send-email-david.a.cohen@linux.intel.com> Date: Tue, 28 Oct 2014 11:17:35 +0100 Message-ID: Subject: Re: [PATCH v2] pinctrl: baytrail: show output gpio state correctly on Intel Baytrail From: Linus Walleij To: David Cohen Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Felipe Balbi , stable , Mathias Nyman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 14, 2014 at 7:54 PM, David Cohen wrote: > Even if a gpio pin is set to output, we still need to set INPUT_EN > functionality (by clearing INPUT_EN bit) to be able to read the pin's > level. > > E.g. without this change, we'll always read low level state from sysfs. > > Cc: # v3.14+ > Cc: Mathias Nyman > Signed-off-by: David Cohen > --- > > v1 to v2: improved patch's body description as requested by Felipe Balbi This v2 version applied for fixes with Felipe's review tag. Sorry for slow catching up with email :( Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/