Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S262670AbSLLLaJ>; Thu, 12 Dec 2002 06:30:09 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S262692AbSLLLaJ>; Thu, 12 Dec 2002 06:30:09 -0500
Received: from boden.synopsys.com ([204.176.20.19]:63642 "HELO
	boden.synopsys.com") by vger.kernel.org with SMTP
	id <S262670AbSLLLaI>; Thu, 12 Dec 2002 06:30:08 -0500
Date: Thu, 12 Dec 2002 12:37:38 +0100
From: Alex Riesen <alexander.riesen@synopsys.COM>
To: mdew <mdew@orcon.net.nz>
Cc: linux-kernel@vger.kernel.org, chuchelo@krasu.ru
Subject: Re: File still being accessed?
Message-ID: <20021212113738.GB1647@riesen-pc.gr05.synopsys.com>
Reply-To: alexander.riesen@synopsys.COM
References: <1039665790.602.5.camel@nirvana> <20021212085229.GA1647@riesen-pc.gr05.synopsys.com> <1039690223.463.11.camel@nirvana>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1039690223.463.11.camel@nirvana>
User-Agent: Mutt/1.4i
Organization: Synopsys, Inc.
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1642
Lines: 42

mdew, Thu, Dec 12, 2002 11:50:19 +0100:
> > > Under Linux 2.5.51 Ive noticed that Downloader4X (Getright-type for
> > > linux) http://www.krasu.ru/soft/chuchelo/
> > > 
> > > when trying to resume a file, It thinks the file is still being
> > > accessed, however under 2.4, it has no such problem. Is this a bug in
> > > 2.5.x still? any patches available that could help?
> > which d4x version, what _exactly_ the message states?
> > -alex
> I've tried both D4X GTK2 (2.4.0-rc1) based and GTK1.2.x (1.3.0) based, same results.
> 
> I add a download, let it partially download, then press
> "Continue/Restart Downloads"
> 
> -> Retry 1 ...
> -> Trying to connect...
> -> Socket was opened!
> -> Trying to create a file
> +  File was created!
> !! File is already opened by another download!
> !! Downloading was failed...

The problem is advisory file locking. I'll try to debug
it later, but something changed in how
fcntl(fd, F_SETLK,{...,F_WRLCK,...}) works. It return an
error now. Or maybe d4x just fails to unlock it, it doesn't
check if unlock failed.
The program doesn't show the real value of errno, just
handles EINVAL and ENOLCK, so exact analisys is not possible
apart something bad happened ("is already opened").
The EINTR case, for instance, would cause similar behaviour.

I suppose d4x just incorrectly uses it, but cannot say anything
for sure.
The maintainer is notified.

-alex
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/