Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754474AbaJ1Ogq (ORCPT ); Tue, 28 Oct 2014 10:36:46 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:24498 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbaJ1Ogn (ORCPT ); Tue, 28 Oct 2014 10:36:43 -0400 Message-ID: <544FA9F7.1020101@imgtec.com> Date: Tue, 28 Oct 2014 14:36:39 +0000 From: Qais Yousef User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: , Arnd Bergmann , "Grant Likely" , Rob Herring , , Subject: Re: [PATCH 03/11] drivers: char: add AXD Audio Processing IP driver References: <1414495589-8579-1-git-send-email-qais.yousef@imgtec.com> <1414495589-8579-4-git-send-email-qais.yousef@imgtec.com> <20141028141038.GA18384@kroah.com> In-Reply-To: <20141028141038.GA18384@kroah.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28/2014 02:10 PM, Greg Kroah-Hartman wrote: > On Tue, Oct 28, 2014 at 11:26:21AM +0000, Qais Yousef wrote: >> AXD is Audio Processing IP by Imagination Technologies that can >> perform decoding, encoding, equalisation, resampling, mixing, >> synchronisation and audio playback. > Isn't that a codec? Why is this a "char" driver and not one that fits > into our existing audio subsystem? As far as I understand it doesn't fit into current alsa framework because of a number of unsupported features that we need. Specifically the range of compressed decoders we support and their configurations and encoding. I might have gotten it wrong though so I'll wait to see what alsa people say. >> this patch adds defs and initialisation files > Spell check :) Hmm UK spelling vs US spelling :) Unless you mean the defs then I'll expand it. >> Signed-off-by: Qais Yousef >> Cc: Arnd Bergmann >> Cc: Greg Kroah-Hartman >> Cc: Grant Likely >> Cc: Rob Herring >> Cc: >> Cc: >> --- >> drivers/char/axd/axd_api.h | 641 +++++++++++++++++++++++++ >> drivers/char/axd/axd_module.c | 1064 +++++++++++++++++++++++++++++++++++++++++ >> drivers/char/axd/axd_module.h | 99 ++++ >> include/linux/axd.h | 32 ++ >> 4 files changed, 1836 insertions(+) >> create mode 100644 drivers/char/axd/axd_api.h >> create mode 100644 drivers/char/axd/axd_module.c >> create mode 100644 drivers/char/axd/axd_module.h >> create mode 100644 include/linux/axd.h >> >> diff --git a/drivers/char/axd/axd_api.h b/drivers/char/axd/axd_api.h >> new file mode 100644 >> index 000000000000..0d732f173f55 >> --- /dev/null >> +++ b/drivers/char/axd/axd_api.h >> @@ -0,0 +1,641 @@ >> +/* >> + * Copyright (C) 2011-2014 Imagination Technologies Ltd. >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License >> + * as published by the Free Software Foundation; either version 2 >> + * of the License, or (at your option) any later version. > Do you really mean "any later version"? > Nope. I probably copied that from the wrong source. >> + * >> + * Main API to the AXD for access from the host. >> + */ >> +#ifndef AXD_API_H_ >> +#define AXD_API_H_ >> + >> +#include >> + >> + >> +#define THREAD_COUNT 4 >> +#define AXD_MAX_PIPES 3 >> + >> + >> +#define AXD_DESCRIPTOR_READY_BIT 0x80000000 >> +#define AXD_DESCRIPTOR_INUSE_BIT 0x40000000 >> +#define AXD_DESCRIPTOR_EOS_BIT 0x20000000 >> +#define AXD_DESCRIPTOR_SIZE_MASK 0x0000FFFF >> + >> +struct axd_buffer_desc { >> + uint32_t status_size; >> + uint32_t data_ptr; >> + uint32_t pts_high; >> + uint32_t pts_low; > Please always use standard Linux kernel types, "u32" in this case. OK. Thanks, Qais > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/