Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753330AbaJ1PK3 (ORCPT ); Tue, 28 Oct 2014 11:10:29 -0400 Received: from mail-ig0-f174.google.com ([209.85.213.174]:56905 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbaJ1PK1 (ORCPT ); Tue, 28 Oct 2014 11:10:27 -0400 MIME-Version: 1.0 In-Reply-To: <20141017015322.GB4513@psi-dev26.jf.intel.com> References: <1413227857-555-1-git-send-email-david.a.cohen@linux.intel.com> <543CFC7F.2070607@linux.intel.com> <20141014174535.GA6516@psi-dev26.jf.intel.com> <20141015070812.GM2255@lahna.fi.intel.com> <20141015165542.GA4529@psi-dev26.jf.intel.com> <20141016080123.GW2255@lahna.fi.intel.com> <20141017015322.GB4513@psi-dev26.jf.intel.com> Date: Tue, 28 Oct 2014 16:10:26 +0100 Message-ID: Subject: Re: [RFC/PATCH] gpio/pinctrl: baytrail: move gpio driver from pinctrl to gpio directory From: Linus Walleij To: David Cohen Cc: Mika Westerberg , Mathias Nyman , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 17, 2014 at 3:53 AM, David Cohen wrote: > On Thu, Oct 16, 2014 at 11:01:23AM +0300, Mika Westerberg wrote: >> In an ideal world, yes. However, the reality has shown that BIOS/FW gets >> these wrong and we need to work it around in the OS. > > But we never upstream these workarounds, right? :) Unless you discover it after it hits the market, right? I think this driver is just fine exactly where it is. Besides, the driver is fully aware of all its pins, and just look at all the pull up etc information displayed by byt_gpio_dbg_show(), it doesn't get more pin control than that even if you don't implement the pin control API. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/