Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754631AbaJ1P77 (ORCPT ); Tue, 28 Oct 2014 11:59:59 -0400 Received: from mga01.intel.com ([192.55.52.88]:55865 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754268AbaJ1P75 (ORCPT ); Tue, 28 Oct 2014 11:59:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,803,1406617200"; d="scan'208";a="612843494" Message-ID: <544FBCFA.4070400@linux.intel.com> Date: Tue, 28 Oct 2014 08:57:46 -0700 From: Darren Hart User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Mika Westerberg , "Rafael J. Wysocki" CC: Alexandre Courbot , Linus Walleij , Arnd Bergmann , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties References: <1414494927-204923-1-git-send-email-mika.westerberg@linux.intel.com> In-Reply-To: <1414494927-204923-1-git-send-email-mika.westerberg@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28/14 4:15, Mika Westerberg wrote: > acpi_dev_add_driver_gpios() makes it possible to set up mapping between > properties and ACPI GpioIo resources in a driver, so we can take index > parameter in acpi_find_gpio() into use with _DSD device properties now. > > This index can be used to select a GPIO from a property with multiple > GPIOs: > > Package () { > "data-gpios", > Package () { > \_SB.GPIO, 0, 0, 0, > \_SB.GPIO, 1, 0, 0, > \_SB.GPIO, 2, 0, 1, > } > } > > In order to retrieve the last GPIO from a driver we can simply do: > > desc = devm_gpiod_get_index(dev, "data", 2); > > and so on. > > Signed-off-by: Mika Westerberg Nice, that was a gap that had been gnawing at me. Thanks Mika :-) Acked-by: Darren Hart -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/