Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752682AbaJ1QrV (ORCPT ); Tue, 28 Oct 2014 12:47:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50799 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbaJ1QrS (ORCPT ); Tue, 28 Oct 2014 12:47:18 -0400 Date: Tue, 28 Oct 2014 17:47:15 +0100 Message-ID: From: Takashi Iwai To: Lars-Peter Clausen Cc: Mark Brown , Max Filippov , alsa-devel@alsa-project.org, Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , linux-xtensa@linux-xtensa.org, Ian Campbell , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Kumar Gala , Grant Likely Subject: Re: [alsa-devel] [PATCH] ASoC: add xtensa xtfpga I2S interface and platform In-Reply-To: <544FC6B1.1060002@metafoo.de> References: <1414436825-19416-1-git-send-email-jcmvbkbc@gmail.com> <544FBD20.5000604@metafoo.de> <20141028160414.GY18557@sirena.org.uk> <544FC6B1.1060002@metafoo.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 28 Oct 2014 17:39:13 +0100, Lars-Peter Clausen wrote: > > On 10/28/2014 05:04 PM, Mark Brown wrote: > > On Tue, Oct 28, 2014 at 04:58:24PM +0100, Lars-Peter Clausen wrote: > >> On 10/27/2014 08:07 PM, Max Filippov wrote: > > > >>> + if (tx_active) { > >>> + if (i2s->tx_fifo_high < 256) > >>> + xtfpga_i2s_refill_fifo(i2s); > >>> + else > >>> + tasklet_hi_schedule(&i2s->refill_fifo); > > > >> Maybe use threaded IRQs instead of IRQ + tasklet. > > > > Is that going to play nicely with the fact that the interrupt can be > > shared and the desire to (AFAICT) do NAPI style stuff with the interrupt > > disabled for long periods? > > > > Threaded interrupts got support for interrupt sharing a while ago, so I > guess yes. I think it will even work better than the tasklet approach. You > can configure the IRQ to disable itself as long as the thread is running. Yes, I tested the threaded irq with PCI drivers using shared irqs and worked well. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/