Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753587AbaJ1S4J (ORCPT ); Tue, 28 Oct 2014 14:56:09 -0400 Received: from terminus.zytor.com ([198.137.202.10]:54270 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752904AbaJ1S4E (ORCPT ); Tue, 28 Oct 2014 14:56:04 -0400 Date: Tue, 28 Oct 2014 11:54:26 -0700 From: tip-bot for Jiang Liu Message-ID: Cc: yinghai@kernel.org, konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, david.a.cohen@linux.intel.com, hpa@zytor.com, bhelgaas@google.com, jiang.liu@linux.intel.com, benh@kernel.crashing.org, rjw@rjwysocki.net, bp@alien8.de, mingo@kernel.org, joro@8bytes.org, rdunlap@infradead.org, tglx@linutronix.de, andriy.shevchenko@linux.intel.com, tony.luck@intel.com, hpa@linux.intel.com, gregkh@linuxfoundation.org Reply-To: yinghai@kernel.org, konrad.wilk@oracle.com, hpa@zytor.com, linux-kernel@vger.kernel.org, david.a.cohen@linux.intel.com, bhelgaas@google.com, jiang.liu@linux.intel.com, benh@kernel.crashing.org, rjw@rjwysocki.net, bp@alien8.de, mingo@kernel.org, joro@8bytes.org, rdunlap@infradead.org, tglx@linutronix.de, andriy.shevchenko@linux.intel.com, tony.luck@intel.com, hpa@linux.intel.com, gregkh@linuxfoundation.org In-Reply-To: <1414387308-27148-3-git-send-email-jiang.liu@linux.intel.com> References: <1414387308-27148-3-git-send-email-jiang.liu@linux.intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86, intel-mid: Create IRQs for APB timers and RTC timers Git-Commit-ID: 287d0625f072e78bb438e6a5f0cf106f9aa03d60 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 287d0625f072e78bb438e6a5f0cf106f9aa03d60 Gitweb: http://git.kernel.org/tip/287d0625f072e78bb438e6a5f0cf106f9aa03d60 Author: Jiang Liu AuthorDate: Mon, 27 Oct 2014 13:21:32 +0800 Committer: Thomas Gleixner CommitDate: Tue, 28 Oct 2014 19:50:50 +0100 x86, intel-mid: Create IRQs for APB timers and RTC timers Intel MID platforms has no legacy interrupts, so no IRQ descriptors preallocated. We need to call mp_map_gsi_to_irq() to create IRQ descriptors for APB timers and RTC timers, otherwise it may cause invalid memory access as: [ 0.116839] BUG: unable to handle kernel NULL pointer dereference at 0000003a [ 0.123803] IP: [] setup_irq+0xf/0x4d Tested-by: Andy Shevchenko Signed-off-by: Jiang Liu Cc: Konrad Rzeszutek Wilk Cc: Tony Luck Cc: Joerg Roedel Cc: Greg Kroah-Hartman Cc: H. Peter Anvin Cc: Benjamin Herrenschmidt Cc: Rafael J. Wysocki Cc: Bjorn Helgaas Cc: Randy Dunlap Cc: Yinghai Lu Cc: Borislav Petkov Cc: David Cohen Cc: # 3.17 Link: http://lkml.kernel.org/r/1414387308-27148-3-git-send-email-jiang.liu@linux.intel.com Signed-off-by: Thomas Gleixner --- arch/x86/kernel/apb_timer.c | 2 -- arch/x86/platform/intel-mid/sfi.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/apb_timer.c b/arch/x86/kernel/apb_timer.c index 5972b10..b708738 100644 --- a/arch/x86/kernel/apb_timer.c +++ b/arch/x86/kernel/apb_timer.c @@ -185,8 +185,6 @@ static void apbt_setup_irq(struct apbt_dev *adev) irq_modify_status(adev->irq, 0, IRQ_MOVE_PCNTXT); irq_set_affinity(adev->irq, cpumask_of(adev->cpu)); - /* APB timer irqs are set up as mp_irqs, timer is edge type */ - __irq_set_handler(adev->irq, handle_edge_irq, 0, "edge"); } /* Should be called with per cpu */ diff --git a/arch/x86/platform/intel-mid/sfi.c b/arch/x86/platform/intel-mid/sfi.c index 3c53a90..c14ad34 100644 --- a/arch/x86/platform/intel-mid/sfi.c +++ b/arch/x86/platform/intel-mid/sfi.c @@ -106,6 +106,7 @@ int __init sfi_parse_mtmr(struct sfi_table_header *table) mp_irq.dstapic = MP_APIC_ALL; mp_irq.dstirq = pentry->irq; mp_save_irq(&mp_irq); + mp_map_gsi_to_irq(pentry->irq, IOAPIC_MAP_ALLOC); } return 0; @@ -176,6 +177,7 @@ int __init sfi_parse_mrtc(struct sfi_table_header *table) mp_irq.dstapic = MP_APIC_ALL; mp_irq.dstirq = pentry->irq; mp_save_irq(&mp_irq); + mp_map_gsi_to_irq(pentry->irq, IOAPIC_MAP_ALLOC); } return 0; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/