Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbaJ1TPf (ORCPT ); Tue, 28 Oct 2014 15:15:35 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.44.111]:60891 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbaJ1TPc convert rfc822-to-8bit (ORCPT ); Tue, 28 Oct 2014 15:15:32 -0400 From: Paul Zimmerman To: "balbi@ti.com" CC: Huang Rui , Alan Stern , Bjorn Helgaas , Greg Kroah-Hartman , Heikki Krogerus , Jason Chang , "Vincent Wan" , Tony Li , "linux-usb@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported Thread-Topic: [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported Thread-Index: AQHP8qYgj9F4B7TzsUusYGn8s5197ZxF2FcQgAB374D//4rigIAAeAUA//+N3eA= Date: Tue, 28 Oct 2014 19:15:29 +0000 Message-ID: References: <1414497280-3126-1-git-send-email-ray.huang@amd.com> <1414497280-3126-2-git-send-email-ray.huang@amd.com> <20141028185059.GE25735@saruman> <20141028190122.GF25735@saruman> In-Reply-To: <20141028190122.GF25735@saruman> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.9.64.241] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Felipe Balbi [mailto:balbi@ti.com] > Sent: Tuesday, October 28, 2014 12:01 PM > > On Tue, Oct 28, 2014 at 06:55:50PM +0000, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:balbi@ti.com] > > > Sent: Tuesday, October 28, 2014 11:51 AM > > > > > > On Tue, Oct 28, 2014 at 06:47:08PM +0000, Paul Zimmerman wrote: > > > > > From: Huang Rui [mailto:ray.huang@amd.com] > > > > > Sent: Tuesday, October 28, 2014 4:54 AM > > > > > > > > > > It enables hibernation if the function is set in coreConsultant. > > > > > > > > > > Suggested-by: Felipe Balbi > > > > > Signed-off-by: Huang Rui > > > > > --- > > > > > drivers/usb/dwc3/core.c | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > > > index fa396fc..bf77509 100644 > > > > > --- a/drivers/usb/dwc3/core.c > > > > > +++ b/drivers/usb/dwc3/core.c > > > > > @@ -449,6 +449,7 @@ static int dwc3_core_init(struct dwc3 *dwc) > > > > > case DWC3_GHWPARAMS1_EN_PWROPT_HIB: > > > > > /* enable hibernation here */ > > > > > dwc->nr_scratch = DWC3_GHWPARAMS4_HIBER_SCRATCHBUFS(hwparams4); > > > > > + reg |= DWC3_GCTL_GBLHIBERNATIONEN; > > > > > break; > > > > > default: > > > > > dev_dbg(dwc->dev, "No power optimization available\n"); > > > > > > > > What effect does this have when the controller is in device mode? I > > > > expect it will start generating DWC3_DEVICE_EVENT_HIBER_REQ interrupt > > > > events when this register bit is set. So the dev_WARN_ONCE in > > > > dwc3_gadget_interrupt() will start firing, I think. > > > > > > Ok, so this *has* to wait for proper hibernation support ? > > > > Ah, never mind. Since the hibernation event is not enabled in the > > DEVTEN register, the controller shouldn't generate that event after > > all. So I think it should be OK. Sorry for the noise. > > do you think it's still nice to have a comment here ? Maybe something along the lines of "enabling this bit so that host-mode hibernation will work, device-mode hibernation is not implemented yet"? -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/