Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756542AbaJ2JY0 (ORCPT ); Wed, 29 Oct 2014 05:24:26 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:45127 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755978AbaJ2JYY (ORCPT ); Wed, 29 Oct 2014 05:24:24 -0400 MIME-Version: 1.0 In-Reply-To: <1412259404-5202-1-git-send-email-lisovy@merica.cz> References: <542D46A1.9090905@ti.com> <1412259404-5202-1-git-send-email-lisovy@merica.cz> Date: Wed, 29 Oct 2014 10:24:23 +0100 Message-ID: Subject: Re: [PATCH v3 2/2] mtd: nand: omap: Synchronize the access to the ECC engine From: Frans Klaver To: Rostislav Lisovy Cc: David Woodhouse , Brian Norris , Tony Lindgren , Roger Quadros , linux-mtd@lists.infradead.org, "linux-kernel@vger.kernel.org" , michal.vokac@comap.cz, sojkam1@fel.cvut.cz, Rostislav Lisovy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 2, 2014 at 4:16 PM, Rostislav Lisovy wrote: > > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c > index f0dcdb6..dfae46f 100644 > --- a/drivers/mtd/nand/omap2.c > +++ b/drivers/mtd/nand/omap2.c > @@ -144,8 +144,13 @@ static u_char bch8_vector[] = {0xf3, 0xdb, 0x14, 0x16, 0x8b, 0xd2, 0xbe, 0xcc, > 0xac, 0x6b, 0xff, 0x99, 0x7b}; > static u_char bch4_vector[] = {0x00, 0x6b, 0x31, 0xdd, 0x41, 0xbc, 0x10}; > > +/* Shared among all NAND instances to synchronize the access to the ECC Engine */ > +struct nand_hw_control omap_gpmc_controller = { > + .lock = __SPIN_LOCK_UNLOCKED(omap_gpmc_controller.lock), > + .wq = __WAIT_QUEUE_HEAD_INITIALIZER(omap_gpmc_controller.wq), > +}; > + Any reason not to make this one static? Thanks, Frans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/