Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932739AbaJ2LhR (ORCPT ); Wed, 29 Oct 2014 07:37:17 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:55107 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932461AbaJ2LhM (ORCPT ); Wed, 29 Oct 2014 07:37:12 -0400 Date: Wed, 29 Oct 2014 11:36:34 +0000 From: Mark Brown To: Alison Wang Cc: perex@perex.cz, tiwai@suse.de, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20141029113634.GF18557@sirena.org.uk> References: <1414552896-20797-1-git-send-email-b18965@freescale.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="blhOMs4YVM72OzYk" Content-Disposition: inline In-Reply-To: <1414552896-20797-1-git-send-email-b18965@freescale.com> X-Cookie: FORCE YOURSELF TO RELAX! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] audio: sai: Add Power Management support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --blhOMs4YVM72OzYk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 29, 2014 at 11:21:36AM +0800, Alison Wang wrote: > This patch adds Power Management support for SAI. > Activate regmap cache with REGCACHE_RBTREE, and use Are you sure that REGCACHE_RBTREE is the best option here? For MMIO devices the cost tradeoff for the rbtree is usually higher than people like so flat caches are preferred. But if it works for you that's fine, this shouldn't be *that* performance critical. I'm also a bit surprised that this works without register defaults being provided since we need to make sure we allocate the rbtree nodes outside of the spinlock we use to lock MMIO access - was this tested with mainline? --blhOMs4YVM72OzYk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJUUNFBAAoJECTWi3JdVIfQ2RoH/R78fnjr1p5Nb8zDFRKIXXhB RgnOYVpZJxHKjZX2gtm7V61dSYbWilH+nKZ3vhaeG0H84n8gqvLLFOc+w8OhtRNZ pzZReEutmW+oQCmV7UZYUn1ThprS4ojjTQ+cfBSo8L9gPtRqslhrvD+u4bA92/hk CfWZ8srGW3CK/Vzw3lSkOBmuW3A5ruwShYN9NGyKB2KFNmWZcX4d3Zen9cJvw2M+ MJxF0e7YNvfgc77pEWcmq3flrONr8pit5o2evNsDcqYl7tVM+ij9p3mXtfRE4Wu3 c8cICgv971oVs1EtXEh+qvPsbvUfR/vw8G+nXyTWvaL3l9WWhlScgkpHassLB2g= =ftGc -----END PGP SIGNATURE----- --blhOMs4YVM72OzYk-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/