Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932709AbaJ2MVf (ORCPT ); Wed, 29 Oct 2014 08:21:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39313 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932388AbaJ2MVe (ORCPT ); Wed, 29 Oct 2014 08:21:34 -0400 Date: Wed, 29 Oct 2014 13:21:31 +0100 From: Petr Mladek To: Steven Rostedt Cc: Joe Perches , Al Viro , Andrew Morton , Linus Torvalds , Christine Caulfield , David Teigland , cluster-devel@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] dlm: Use seq_is_full - remove seq_printf returns Message-ID: <20141029122131.GB2148@dhcp128.suse.cz> References: <20140929124246.3e39dac8@gandalf.local.home> <43590057bcb83846acbbcc1fe641f792b2fb7773.1412031505.git.joe@perches.com> <20140930103435.GC2707@dhcp128.suse.cz> <20141027161724.0ec20325@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141027161724.0ec20325@gandalf.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2014-10-27 16:17:24, Steven Rostedt wrote: > Note, I've started with Joe's patches and I'm massaging them for > something I can work with. > > On Tue, 30 Sep 2014 12:34:35 +0200 > Petr Mladek wrote: > > > > > - rv = seq_printf(s, "\"\nInvalid master %d\n", > > > - res->res_nodeid); > > > - if (rv) > > > + seq_printf(s, "\"\nInvalid master %d\n", res->res_nodeid); > > > + if (seq_is_full(s)) > > > goto out; > > > > I would check for seq_overflow() > > > > Etc. There are needed many more changes if we agree on introducing > > seq_is_full() and seq_overflow(). > > As I'm looking at this code, I'm thinking that we never > really care about seq_is_full(). We only really care if > seq_overflowed(), in which the contents will be discarded. > > Rational? Because if we break when seq_is_full(), my new logic wont > throw away the result. If we break out of the function when it's full > and not when it has overflowed, then we may never print out the rest of > the content, as the seq_file code will still use a full buffer that > hasn't overflowed. > > I'm thinking of switching everything to use seq_has_overflowed() and > try again. > > Thoughts? Sounds good to me. Best Regards, Petr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/