From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Alexandre Courbot <acourbot@nvidia.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>, Darren Hart <dvhart@linux.intel.com>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties
Date: Wed, 29 Oct 2014 15:42:23 +0100
Message-ID: <1738599.RytCx391OM@vostro.rjw.lan>
User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20141029085429.GJ1304@lahna.fi.intel.com>
References: <1414494927-204923-1-git-send-email-mika.westerberg@linux.intel.com> <54509A3B.5090709@nvidia.com> <20141029085429.GJ1304@lahna.fi.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org

On Wednesday, October 29, 2014 10:54:29 AM Mika Westerberg wrote:
> On Wed, Oct 29, 2014 at 04:41:47PM +0900, Alexandre Courbot wrote:
> > On 10/29/2014 06:59 AM, Rafael J. Wysocki wrote:
> > >On Tuesday, October 28, 2014 01:15:27 PM Mika Westerberg wrote:
> > >>acpi_dev_add_driver_gpios() makes it possible to set up mapping between
> > >>properties and ACPI GpioIo resources in a driver, so we can take index
> > >>parameter in acpi_find_gpio() into use with _DSD device properties now.
> > >>
> > >>This index can be used to select a GPIO from a property with multiple
> > >>GPIOs:
> > >>
> > >>   Package () {
> > >>   	"data-gpios",
> > >>   	Package () {
> > >>   		\_SB.GPIO, 0, 0, 0,
> > >>   		\_SB.GPIO, 1, 0, 0,
> > >>   		\_SB.GPIO, 2, 0, 1,
> > >>   	}
> > >>   }
> > >>
> > >>In order to retrieve the last GPIO from a driver we can simply do:
> > >>
> > >>   desc = devm_gpiod_get_index(dev, "data", 2);
> > >>
> > >>and so on.
> > >>
> > >>Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > >
> > >Cool. :-)
> > >
> > >Any objections anyone?
> > 
> > Looks good to me!
> > 
> > Acked-by: Alexandre Courbot <acourbot@nvidia.com>
> 
> Thanks!
> 
> > Since this looks like a bug fix, shouldn't this be squashed into the
> > relevant patch of the device-properties set?
> 
> I agree.

Well, except that the set is in my linux-next branch now and I very much
prefer to do fixes on top of it.

Besides, I'm not sure if that even matters for the current series.

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/