Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934091AbaJ2P4b (ORCPT ); Wed, 29 Oct 2014 11:56:31 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:40970 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932994AbaJ2P43 (ORCPT ); Wed, 29 Oct 2014 11:56:29 -0400 Date: Wed, 29 Oct 2014 16:56:20 +0100 From: Sabrina Dubroca To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, jeffrey.t.kirsher@intel.com Subject: e1000_netpoll(): disable_irq() triggers might_sleep() on linux-next Message-ID: <20141029155620.GA4886@kria> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit e22b886a8a43b ("sched/wait: Add might_sleep() checks") included in today's linux-next added a check that fires on e1000 with netpoll: BUG: sleeping function called from invalid context at kernel/irq/manage.c:104 in_atomic(): 1, irqs_disabled(): 1, pid: 1, name: systemd no locks held by systemd/1. irq event stamp: 10102965 hardirqs last enabled at (10102965): [] vprintk_emit+0x2dd/0x6a0 hardirqs last disabled at (10102964): [] vprintk_emit+0x77/0x6a0 softirqs last enabled at (10102342): [] __do_softirq+0x27a/0x6f0 softirqs last disabled at (10102337): [] irq_exit+0x56/0xe0 Preemption disabled at:[] printk_emit+0x31/0x33 CPU: 1 PID: 1 Comm: systemd Not tainted 3.18.0-rc2-next-20141029-dirty #222 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140617_173321-var-lib-archbuild-testing-x86_64-tobias 04/01/2014 ffffffff81a82291 ffff88001e743978 ffffffff817df31d 0000000000000000 0000000000000000 ffff88001e7439a8 ffffffff8108dfa2 ffff88001e7439a8 ffffffff81a82291 0000000000000068 0000000000000000 ffff88001e7439d8 Call Trace: [] dump_stack+0x4f/0x7c [] ___might_sleep+0x182/0x2b0 [] __might_sleep+0x3a/0xc0 [] synchronize_irq+0x38/0xa0 [] ? __disable_irq_nosync+0x43/0x70 [] disable_irq+0x20/0x30 [] e1000_netpoll+0x23/0x60 [] netpoll_poll_dev+0x72/0x3a0 [] ? _raw_spin_trylock+0x73/0x90 [] ? netpoll_send_skb_on_dev+0x1df/0x2e0 [] netpoll_send_skb_on_dev+0x1b7/0x2e0 [] netpoll_send_udp+0x2e3/0x490 [] ? write_msg+0x51/0x140 [] write_msg+0xcf/0x140 [] call_console_drivers.constprop.22+0x13b/0x2a0 [] console_unlock+0x39d/0x500 [] ? vprintk_emit+0x31e/0x6a0 [] vprintk_emit+0x33c/0x6a0 [] ? might_fault+0x5e/0xc0 [] printk_emit+0x31/0x33 [] devkmsg_write+0xbd/0x110 [] do_iter_readv_writev+0x65/0xa0 [] do_readv_writev+0xe2/0x290 [] ? vprintk+0x30/0x30 [] ? rcu_read_lock_held+0x6d/0x70 [] ? __fget_light+0xc6/0xd0 [] vfs_writev+0x3c/0x50 [] SyS_writev+0x4d/0xe0 [] system_call_fastpath+0x16/0x1b I'm able to reproduce it consistently by sending a lot of packets from that interface while writing to /dev/kmsg with netconsole enabled. Just writing to /dev/kmsg isn't enough. # with ping -f or pktgen running for i in `seq 1 20` ; do echo '............................................' > /dev/kmsg ; done -- Sabrina -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/