Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934235AbaJ2QHS (ORCPT ); Wed, 29 Oct 2014 12:07:18 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:51536 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933423AbaJ2QHP (ORCPT ); Wed, 29 Oct 2014 12:07:15 -0400 Message-ID: <1414598848.32383.4.camel@mm-sol.com> Subject: Re: [PATCH 0/2] Qualcomm PM8941 power key driver From: "Ivan T. Ivanov" To: Bjorn Andersson Cc: Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Grant Likely , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Date: Wed, 29 Oct 2014 18:07:28 +0200 In-Reply-To: <20141024152350.GD28611@sonymobile.com> References: <1412644321-27683-1-git-send-email-bjorn.andersson@sonymobile.com> <1412672510.1027.57.camel@iivanov-dev> <20141007184640.GB31125@sonymobile.com> <1412761807.13569.12.camel@iivanov-dev> <20141024152350.GD28611@sonymobile.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.6-fta3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, On Fri, 2014-10-24 at 08:23 -0700, Bjorn Andersson wrote: > On Wed 08 Oct 02:50 PDT 2014, Ivan T. Ivanov wrote: > > > On Tue, 2014-10-07 at 11:46 -0700, Bjorn Andersson wrote: > > > On Tue 07 Oct 02:01 PDT 2014, Ivan T. Ivanov wrote: > > > > > > > Hi Bjorn, > > > > > > > > On Mon, 2014-10-06 at 18:11 -0700, Bjorn Andersson wrote: > [..] > > > > > create mode 100644 drivers/input/misc/pm8941-pwrkey.c > > > > > > > > Any reason why we cannot reuse pm8xxx-pwrkey driver? It have been > > > > converted to regmap already. > > > > > > > > > > The boilerplate code is the same, > > > > The boilerplate code is almost 100% :-) > > > > > but configuration registers have different > > > layout and values written in them are different. > > > > We talk about 3 registers and 2 bit defines. struct regmap_field > > should be able to help here. > > > > You're totally right, we could rewrite the driver to use regmap_field and make > the rest of the differences conditional. In my eyes we end up with two drivers > in one file - but it can be done. > > A difference however is that in pm8941 the ps hold behavious (reboot vs power > off) is controlled by this same block. So I have an additional patch that adds > a restart handler here that sets the pmic in the right state before we pull > pshold (but I haven't been able to test it properly). > > In pm8xxx this is handled in the pmic misc block and does not belong in this > driver. Ok, Your plan is to bring up support for QPNP power-on PMIC sub function into this driver. In this case, I agree, it will be cleaner to have separate driver for this. Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/