Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756067AbaJ2TKP (ORCPT ); Wed, 29 Oct 2014 15:10:15 -0400 Received: from www.linutronix.de ([62.245.132.108]:58319 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbaJ2TKM (ORCPT ); Wed, 29 Oct 2014 15:10:12 -0400 Date: Wed, 29 Oct 2014 20:10:07 +0100 (CET) From: Thomas Gleixner To: Kevin Cernekee cc: Arnd Bergmann , Florian Fainelli , Jason Cooper , Ralf Baechle , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Maxime Bizon , Jonas Gorski , Linux MIPS Mailing List Subject: Re: [PATCH 01/11] irqchip: Allow irq_reg_{readl,writel} to use __raw_{readl_writel} In-Reply-To: Message-ID: References: <1414555138-6500-1-git-send-email-cernekee@gmail.com> <11255905.1JsQYcArO7@wuerfel> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Oct 2014, Kevin Cernekee wrote: > Thomas: > > How does that work with multi arch kernels? > > I am assuming this question refers to e.g. CONFIG_ARCH_MULTIPLATFORM > > If GENERIC_IRQ_CHIP is being used, the current implementation of > generic-chip.c will have to pick one global definition of > irq_reg_{readl,writel} for all supported SoCs. > > One possibility is that individual irqchip drivers requiring special > accessors can pass in their own function pointers, similar to this: > > struct sdhci_ops { > #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS > u32 (*read_l)(struct sdhci_host *host, int reg); > u16 (*read_w)(struct sdhci_host *host, int reg); > u8 (*read_b)(struct sdhci_host *host, int reg); > void (*write_l)(struct sdhci_host *host, u32 val, int reg); > void (*write_w)(struct sdhci_host *host, u16 val, int reg); > void (*write_b)(struct sdhci_host *host, u8 val, int reg); > #endif > > and fall back to readl/writel if none are supplied. It would be nice > if this provided common definitions for the __raw_ and maybe the BE > variants too. > > Or, we could add IRQ_GC_NATIVE_IO and/or IRQ_GC_BE_IO to enum irq_gc_flags. I definitely prefer to have these options in the generic chip implementation so we avoid that driver writers duplicate code in creative and wrong ways. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/