Message-ID: <54514BF6.1010201@nod.at>
Date: Wed, 29 Oct 2014 21:20:06 +0100
From: Richard Weinberger <richard@nod.at>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0
MIME-Version: 1.0
To: Andrew Murray <amurray@embedded-bits.co.uk>
CC: Artem Bityutskiy <dedekind1@gmail.com>, linux-mtd@lists.infradead.org,
        LKML <linux-kernel@vger.kernel.org>,
        Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Subject: Re: [PATCH 1/2] UBI: Implement UBI_METAONLY
References: <1414594338-14695-1-git-send-email-richard@nod.at> <CAPcvp5HBnuAHTwFHLJ1Ve6o2MSeQ8Qnn6x7Q0wD2G-yP6p7OLA@mail.gmail.com>
In-Reply-To: <CAPcvp5HBnuAHTwFHLJ1Ve6o2MSeQ8Qnn6x7Q0wD2G-yP6p7OLA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

Am 29.10.2014 um 21:11 schrieb Andrew Murray:
> On 29 October 2014 14:52, Richard Weinberger <richard@nod.at> wrote:
>> diff --git a/include/linux/mtd/ubi.h b/include/linux/mtd/ubi.h
>> index c3918a0..82b693f 100644
>> --- a/include/linux/mtd/ubi.h
>> +++ b/include/linux/mtd/ubi.h
>> @@ -34,11 +34,13 @@
>>   * UBI_READONLY: read-only mode
>>   * UBI_READWRITE: read-write mode
>>   * UBI_EXCLUSIVE: exclusive mode
>> + * UBI_METAONLY: modify voulme meta data only
> 
> Typo - s/voulme/volume/g

Thanks. :)

>>   */
>>  enum {
>>         UBI_READONLY = 1,
>>         UBI_READWRITE,
>> -       UBI_EXCLUSIVE
>> +       UBI_EXCLUSIVE,
>> +       UBI_METAONLY
>>  };
>>
> 
> Also you may want to add something similar to this:
> 
> --- a/drivers/mtd/ubi/ubi.h
> +++ b/drivers/mtd/ubi/ubi.h
> @@ -339,7 +339,7 @@ struct ubi_volume {
>  /**
>   * struct ubi_volume_desc - UBI volume descriptor returned when it is opened.
>   * @vol: reference to the corresponding volume description object
> - * @mode: open mode (%UBI_READONLY, %UBI_READWRITE, or %UBI_EXCLUSIVE)
> + * @mode: open mode (%UBI_READONLY, %UBI_READWRITE, %UBI_EXCLUSIVE or
> %UBI_METAONLY)
>   */
>  struct ubi_volume_desc {
>         struct ubi_volume *vol;
> 
> There is also a similar mention in gluebi.c: 'readers/writes/exclusive'.

Please send a patch for that. :)

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/