Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756920AbaJ3AN6 (ORCPT ); Wed, 29 Oct 2014 20:13:58 -0400 Received: from mail-la0-f48.google.com ([209.85.215.48]:42153 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755207AbaJ3AN4 (ORCPT ); Wed, 29 Oct 2014 20:13:56 -0400 MIME-Version: 1.0 In-Reply-To: References: <1414620056-6675-1-git-send-email-gregkh@linuxfoundation.org> <1414620056-6675-7-git-send-email-gregkh@linuxfoundation.org> From: Andy Lutomirski Date: Wed, 29 Oct 2014 17:13:34 -0700 Message-ID: Subject: Re: kdbus: add code to gather metadata To: Greg Kroah-Hartman Cc: Linux API , "linux-kernel@vger.kernel.org" , John Stultz , Arnd Bergmann , Tejun Heo , Marcel Holtmann , Ryan Lortie , Bastien Nocera , David Herrmann , Djalal Harouni , Simon McVittie , daniel@zonque.org, alban.crequy@collabora.co.uk, Javier Martinez Canillas , Tom Gundersen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 29, 2014 at 3:33 PM, Andy Lutomirski wrote: > On Wed, Oct 29, 2014 at 3:00 PM, Greg Kroah-Hartman > wrote: >> From: Daniel Mack >> >> A connection chooses which metadata it wants to have attached to each >> message it receives with kdbus_cmd_hello.attach_flags. The metadata >> will be attached as items to the messages. All metadata refers to >> information about the sending task at sending time, unless otherwise >> stated. Also, the metadata is copied, not referenced, so even if the >> sending task doesn't exist anymore at the time the message is received, >> the information is still preserved. >> Also, in general, the comments seem to talk about capturing metadata at the time that a connection is opened, but the actual code seems to capture metadata all over the place. I think it needs to be very clear, both in the code and the interface, when metadata is captured. And the ns_eq stuff is too far buried (and not even contained in this patch!) to be easily verified as being correct, whatever correct means in that context. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/