Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757297AbaJ3FmM (ORCPT ); Thu, 30 Oct 2014 01:42:12 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:50701 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbaJ3FmK (ORCPT ); Thu, 30 Oct 2014 01:42:10 -0400 Date: Thu, 30 Oct 2014 05:42:09 +0000 From: Al Viro To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org Subject: [PATCH] fix a leak in bch_cached_dev_run() Message-ID: <20141030054208.GE7996@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Al Viro diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -878,8 +878,11 @@ void bch_cached_dev_run(struct cached_dev *dc) buf[SB_LABEL_SIZE] = '\0'; env[2] = kasprintf(GFP_KERNEL, "CACHED_LABEL=%s", buf); - if (atomic_xchg(&dc->running, 1)) + if (atomic_xchg(&dc->running, 1)) { + kfree(env[1]); + kfree(env[2]); return; + } if (!d->c && BDEV_STATE(&dc->sb) != BDEV_STATE_NONE) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/