Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161197AbaJ3U3Y (ORCPT ); Thu, 30 Oct 2014 16:29:24 -0400 Received: from smtp73.iad3a.emailsrvr.com ([173.203.187.73]:34917 "EHLO smtp73.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933358AbaJ3U3Y (ORCPT ); Thu, 30 Oct 2014 16:29:24 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <54529FA1.8000702@mev.co.uk> Date: Thu, 30 Oct 2014 20:29:21 +0000 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: Hartley Sweeten , "driverdev-devel@linuxdriverproject.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 5/7] staging: comedi: don't allow write() on async command set up for "read" References: <1414672952-1587-1-git-send-email-abbotti@mev.co.uk> <1414672952-1587-6-git-send-email-abbotti@mev.co.uk> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/10/14 18:07, Hartley Sweeten wrote: > On Thursday, October 30, 2014 5:43 AM, Ian Abbott wrote: [snip] >> add_wait_queue(&async->wait_head, &wait); >> on_wait_queue = true; >> @@ -2146,6 +2150,10 @@ static ssize_t comedi_write(struct file *file, const char __user *buf, >> retval = -EACCES; >> break; >> } >> + if (!(async->cmd.flags & CMDF_WRITE)) { >> + retval = -EINVAL; >> + break; >> + } > > Same question as with PATCH 4/7. > > Is this test needed in the while () loop. Also, are the s->busy tests needed here? Yes, for similar reasons. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/