MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 8BIT
Message-id: <5452F32F.8010103@samsung.com>
Date: Fri, 31 Oct 2014 11:25:51 +0900
From: jonghwa3.lee@samsung.com
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120411
 Thunderbird/11.0.1
To: =?UTF-8?B?S3J6eXN6dG9mIEtvesWCb3dza2k=?= <k.kozlowski@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, sre@kernel.org,
        dbaryshkov@gmail.com, dwmw2@infradead.org, anton@enomsg.org,
        pavel@ucw.cz, myungjoo.ham@samsung.com, cw00.choi@samsung.com
Subject: Re: [PATCH 01/10] power: charger-manager: Use thermal subsystem
 interface only to get temperature.
References: <1414672996-28355-1-git-send-email-jonghwa3.lee@samsung.com>
 <1414672996-28355-2-git-send-email-jonghwa3.lee@samsung.com>
 <54523907.4030609@samsung.com>
In-reply-to: <54523907.4030609@samsung.com>
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org

Hi,
On 2014년 10월 30일 22:11, Krzysztof Kozłowski wrote:

> On 30.10.2014 13:43, Jonghwa Lee wrote:
>> It drops the way of using power_supply interface to reference battery's
>> temperature. Then it tries to use thermal subsystem's only. This makes driver
>> more simple and also can remove ifdeferies.
>>
>> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
>> ---
>>  drivers/power/Kconfig                 |    1 +
>>  drivers/power/charger-manager.c       |  113 ++++++++-------------------------
>>  include/linux/power/charger-manager.h |    3 +-
>>  3 files changed, 28 insertions(+), 89 deletions(-)
>>
>> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
>> index 8ff2511..115d153 100644
>> --- a/drivers/power/Kconfig
>> +++ b/drivers/power/Kconfig
>> @@ -317,6 +317,7 @@ config CHARGER_MANAGER
>>  	bool "Battery charger manager for multiple chargers"
>>  	depends on REGULATOR
>>  	select EXTCON
>> +	select THERMAL
> 
> I think both of "select" here could be dangerous. Select should rather
> be used for non-visible errors. Just use "depends on".
> 
>>  }
>> @@ -623,7 +594,7 @@ static int cm_check_thermal_status(struct charger_manager *cm)
>>  		 * occur hazadous result. We have to handle it
>>  		 * depending on battery type.
>>  		 */
>> -		dev_err(cm->dev, "Failed to get battery temperature\n");
>> +		dev_dbg(cm->dev, "Failed to get battery temperature\n");
> 
> A valuable change but not strictly related to the commit. Additionally
> that is a user-visible change. Could you split it to separate patch?
> 
> Best regards,
> Krzysztof
> 
> 


All your comments are acceptable. I'll fix them all.
Thanks for your comments.

Thanks,
Jonghwa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/