Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758050AbaJaKu1 (ORCPT ); Fri, 31 Oct 2014 06:50:27 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:56242 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756393AbaJaKuZ (ORCPT ); Fri, 31 Oct 2014 06:50:25 -0400 MIME-Version: 1.0 In-Reply-To: <1414719509.32208.9.camel@mhfsdcap03> References: <1414561058-23803-1-git-send-email-xudong.chen@mediatek.com> <1414561058-23803-2-git-send-email-xudong.chen@mediatek.com> <1414719509.32208.9.camel@mhfsdcap03> Date: Fri, 31 Oct 2014 11:50:23 +0100 Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: Add I2C bindings for mt65xx/mt81xx. From: Matthias Brugger To: xudong chen Cc: Mark Rutland , arm@kernel.org, Wolfram Sang , srv_heupstream , Sascha Hauer , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , Grant Likely , Jean Delvare , Arnd Bergmann , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-i2c@vger.kernel.org, Yingjoe Chen , Eddie Huang , Nathan Chung , YH Chen Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-10-31 2:38 GMT+01:00 xudong chen : > On Thu, 2014-10-30 at 13:38 +0100, Matthias Brugger wrote: >> 2014-10-29 6:37 GMT+01:00 Xudong Chen : >> > Add devicetree bindings for Mediatek Soc I2C driver. >> > >> > Signed-off-by: Xudong Chen >> > --- >> > .../devicetree/bindings/i2c/i2c-mt6577.txt | 37 ++++++++++++++++++++++ >> > 1 file changed, 37 insertions(+) >> > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt6577.txt >> > >> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt >> > new file mode 100644 >> > index 0000000..b4012c8 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt >> > @@ -0,0 +1,37 @@ >> > +* Mediatek's I2C controller >> > + >> > +The Mediatek's I2C controller is used to interface with I2C devices. >> > + >> > +Required properties: >> > + - compatible: value should be either of the following. >> > + (a) "mtk,mt6577-i2c", for i2c compatible with mt6577 i2c. >> >> Looking on the datasheet of mt6577 it does not seem that this driver >> is really compatible. >> I was not able to find the PATH_DIR register neither in the datasheet >> nor in the source code. >> > Hi, > > The PATH_DIR register named OFFSET_PATH_DIR(0x60) in the source code. > Only MT8135 supports this feature, so it does not contained in mt6577 > datasheet. > I will modify the comment. > >> > + (b) "mtk,mt8127-i2c", for i2c compatible with mt8127 i2c. >> > + (c) "mtk,mt8135-i2c", for i2c compatible with mt8135 i2c. >> > + - reg: physical base address of the controller and dma base, length of memory mapped >> > + region. >> > + - interrupts: interrupt number to the cpu. >> > + - clock-div: the fixed value for frequency divider of clock source in i2c module. >> > + Each IC may be different. >> > + - clocks: clock name from clock manager >> > + - clock-names: clock name used in i2c driver probe >> > + >> > +Optional properties: >> > + - clock-frequency: Frequency in Hz of the bus when transfer, the default value is 100000. >> > + - mediatek,have-pmic: platform can control i2c form special pmic side. > > I will change this to: > - mediatek,have-pmic: platform can control i2c form special pmic side, > only MT8135 supports this. > > Is this OK? We need a multi function device driver for the I2C and the PMIC. Please have a look on my comments in the other thread. Thanks, Matthias > >> > + - mediatek,have-dcm: platform has DCM(hardware digital clock manager) property. >> > + - mediatek,use-push-pull: IO use push-pull mode. >> > + >> > +Example: >> > + >> > + i2c0: i2c@1100d000 { >> > + compatible = "mediatek,mt6577-i2c"; >> > + reg = <0x1100d000 0x70>, >> > + <0x11000300 0x80>; >> > + interrupts = ; >> > + clock-frequency = <100000>; >> > + mediatek,have-pmic; >> > + clock-div = <16>; >> > + clocks = <&i2c0_ck>, <&ap_dma_ck>; >> > + clock-names = "main", "dma"; >> > + }; >> > + >> > -- >> > 1.8.1.1.dirty >> > >> >> >> > > -- motzblog.wordpress.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/