Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759774AbaJaNem (ORCPT ); Fri, 31 Oct 2014 09:34:42 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:46895 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758302AbaJaNel (ORCPT ); Fri, 31 Oct 2014 09:34:41 -0400 Message-ID: <5453905C.2020508@oracle.com> Date: Fri, 31 Oct 2014 09:36:28 -0400 From: Boris Ostrovsky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ingo Molnar CC: hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, tianyu.lan@intel.com, linux-kernel@vger.kernel.org, david.vrabel@citrix.com, xen-devel@lists.xenproject.org Subject: Re: [Xen-devel] [PATCH v3] xen/smp: Use die_complete completion when taking CPU down References: <1413997748-29808-1-git-send-email-boris.ostrovsky@oracle.com> <54514211.9@oracle.com> <20141031101337.GA24204@gmail.com> In-Reply-To: <20141031101337.GA24204@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/2014 06:13 AM, Ingo Molnar wrote: > * Boris Ostrovsky wrote: > >> On 10/22/2014 01:09 PM, Boris Ostrovsky wrote: >>> Commit 2ed53c0d6cc9 ("x86/smpboot: Speed up suspend/resume by avoiding >>> 100ms sleep for CPU offline during S3") introduced completions to CPU >>> offlining process. These completions are not initialized on Xen kernels >>> causing a panic in play_dead_common(). >>> >>> Move handling of die_complete into common routines to make them >>> available to Xen guests. >>> >>> (While at it, move die_complete definition under #ifdef CONFIG_HOTPLUG_CPU) >>> >>> Signed-off-by: Boris Ostrovsky >>> Reviewed-by: David Vrabel >>> --- >>> >>> v3: Don't #ifdef function prototypes in smp.h >>> v2: Keep die_complete private to smpboot.c >>> >>> >>> arch/x86/include/asm/smp.h | 1 + >>> arch/x86/kernel/smpboot.c | 13 +++++++++++-- >>> arch/x86/xen/smp.c | 3 +++ >>> 3 files changed, 15 insertions(+), 2 deletions(-) >> >> Does anything else need to be done in this patch? We have CPU >> hotplug broken currently in Xen and it would be nice to have it >> fixed in rc3. > There's a build warning fix that this change conflicts with: > > db6a00b4bed3 x86/smpboot: Move data structure to its primary usage scope > > it would be nice if you could rebase it to tip:master or > tip:x86/urgent so I can push it upstream ASAP. Thanks Ingo. Will do. -boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/