Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933328AbaJaOzk (ORCPT ); Fri, 31 Oct 2014 10:55:40 -0400 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:51521 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932248AbaJaOzj (ORCPT ); Fri, 31 Oct 2014 10:55:39 -0400 Date: Fri, 31 Oct 2014 14:55:28 +0000 From: Will Deacon To: Weston Andros Adamson Cc: Peng Tao , Trond Myklebust , linux-nfs list , "linux-kernel@vger.kernel.org" Subject: Re: WARNING at fs/nfs/write.c:743 nfs_inode_remove_request with -rc6 Message-ID: <20141031145528.GI6731@arm.com> References: <20140923145356.GD28608@arm.com> <5294BEB2-F20F-4E3E-BFB2-E41806A4F85A@primarydata.com> <20140923152558.GG28608@arm.com> <20140925171545.GR20043@arm.com> <78B8153D-59B7-4DBE-8472-D83338F04338@primarydata.com> <6111EECC-C8C1-4605-98AD-0AF0E1B6DA59@primarydata.com> <20141020135736.GB20301@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 31, 2014 at 02:49:13PM +0000, Weston Andros Adamson wrote: > On Oct 20, 2014, at 9:57 AM, Will Deacon wrote: > > On Sat, Oct 11, 2014 at 02:32:29PM +0100, Weston Andros Adamson wrote: > >> I’ve been very busy, but I haven’t forgotten about your bug report! > > > > No problem, I've been busy too. I just checked with -rc1 and I can reproduce > > the issue there too. > > > >> I think the WARN_ON_ONCE is just wrong, there are cases where the > >> PG_INODE_REF flag is legitimately not set. The flag is set so that sub > >> requests can mimmic the parent request’s reference count. > >> > >> Could you please run the reproducer again, unmount, then check the contents of > >> /proc/fs/nfsfs/servers? > > > > Sure. I just tried this and that file is empty after unmounting. > > Sorry for the delay (again) - I just got back from a two week holiday. > > This is good news! I think we can safely remove this WARN_ON_ONCE and call it a > day… or maybe calling it a month is more accurate ;) Great! Feel free to add my reported-by/tested-by on that patch. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/