Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933440AbaJaPWo (ORCPT ); Fri, 31 Oct 2014 11:22:44 -0400 Received: from mail-qa0-f45.google.com ([209.85.216.45]:62141 "EHLO mail-qa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932570AbaJaPWn (ORCPT ); Fri, 31 Oct 2014 11:22:43 -0400 MIME-Version: 1.0 Date: Fri, 31 Oct 2014 15:22:39 +0000 Message-ID: Subject: arch/microblaze/kernel/head.S: redundant code? From: Adrian McMenamin To: LKML Cc: monstr@monstr.eu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looking at this code at line 78 (in 3.17 kernel) it has: mfs r1, rmsr msrclr r8, 0 cmpu r8, r8, r1 But as far as I can see the result of that comparison is never used - the comments state it is to test if the msrclr instruction is enabled. Haven't posted a patch because I am using the code to understand how to write my own boot code for a very specific Microblaze application - but perhaps someone with real expertise could look and/or tell me I'm wrong? Cheers Adrian (apologies to Michal Simek for getting this twice) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/