Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756851AbaJaPzR (ORCPT ); Fri, 31 Oct 2014 11:55:17 -0400 Received: from mail-oi0-f47.google.com ([209.85.218.47]:56838 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbaJaPzN (ORCPT ); Fri, 31 Oct 2014 11:55:13 -0400 MIME-Version: 1.0 In-Reply-To: <54534C17.7050703@samsung.com> References: <1414666240-16782-1-git-send-email-addy.ke@rock-chips.com> <1414727409-6765-1-git-send-email-addy.ke@rock-chips.com> <54534C17.7050703@samsung.com> Date: Fri, 31 Oct 2014 08:55:12 -0700 X-Google-Sender-Auth: WmZHoz5It_ipOkPLlLBDzL1CJdU Message-ID: Subject: Re: [PATCH v2] mmc: dw_mmc: add support for the other bit of sdio interrupt From: Doug Anderson To: Jaehoon Chung Cc: Addy Ke , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Seungwon Jeon , Chris Ball , Ulf Hansson , Dinh Nguyen , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Olof Johansson , Sonny Rao , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "zhenfu.fang" , Eddie Cai , lintao , chenfen , zyf , Jianqun Xu , Tao Huang , Chris , =?UTF-8?B?5aea5pm65oOF?= , han jiang , Kever Yang , zhangqing , Lin Huang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jaehoon, On Fri, Oct 31, 2014 at 1:45 AM, Jaehoon Chung wrote: > Hi, Addy. > > On 10/31/2014 12:50 PM, Addy Ke wrote: >> The bit of sdio interrupt is 16 in designware implementation, >> but it is 24 in RK3288. This patch add sdio_id0 for the number >> of slot0 in the SDIO interrupt registers, which can be set in >> platform DT table, such as: >> - rockchip,sdio-interrupt-slot0 = <8>; > > I have a question. (It's not important question) > You mentioned the sdio-irq bit used from 24 to 31, right? > Then what interrupts are used from 16 to 23 at RK3288? Just reserved? In my TRM 16 shows as "data_nobusy". A quick search doesn't show any documentation for what this means. 17-23 and 25-31 are reserved. Note that (of course) there's no actual support for more than one slot on rk3288, so claiming that "24-31" is SDIO INT is a little silly, but I agree that it's probably is the best way to fit into the existing code until someone gets around to removing the whole multi-slot cruft. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/