Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757992AbaJaQDm (ORCPT ); Fri, 31 Oct 2014 12:03:42 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:39734 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbaJaQDk (ORCPT ); Fri, 31 Oct 2014 12:03:40 -0400 MIME-Version: 1.0 X-Originating-IP: [2a01:e35:2434:4600:7553:d774:575d:8267] In-Reply-To: References: <1414433284-31719-1-git-send-email-a.motakis@virtualopensystems.com> <1414433284-31719-15-git-send-email-a.motakis@virtualopensystems.com> From: Antonios Motakis Date: Fri, 31 Oct 2014 17:03:19 +0100 Message-ID: Subject: Re: [PATCH v9 14/19] vfio: move eventfd support code for VFIO_PCI to a separate file To: Bjorn Helgaas Cc: kvm-arm , "open list:INTEL IOMMU (VT-d)" , "alex.williamson@redhat.com" , Will Deacon , VirtualOpenSystems Technical Team , Christoffer Dall , Eric Auger , Kim Phillips , Marc Zyngier , Alexander Gordeev , open list , "open list:VFIO DRIVER" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 27, 2014 at 8:16 PM, Bjorn Helgaas wrote: > Hi Antonios, > > On Mon, Oct 27, 2014 at 12:07 PM, Antonios Motakis > wrote: >> The virqfd functionality that is used by VFIO_PCI to implement interrupt >> masking and unmasking via an eventfd, is generic enough and can be reused >> by another driver. Move it to a separate file in order to allow the code >> to be shared. >> >> Also properly export virqfd_enable and virqfd_disable in the process. > > Alex will handle this, not me, but my personal preference is to avoid > doing things "in the process" because the small changes get lost in > the big patch. > > I'd rather see a strict move that changes no code at all (except > things like necessary Makefile changes), followed by a smaller patch > that does the additional stuff. > > Does "properly export" mean that those functions were previously > *improperly* exported and the way they used to be exported caused a > problem? Or does it just mean "export"? It just means "export", but you are right there is no reason why to export it in this patch. I will move it to one of the next patches. > > Bjorn > >> Signed-off-by: Antonios Motakis >> --- >> drivers/vfio/Makefile | 4 +- >> drivers/vfio/pci/vfio_pci_intrs.c | 213 ----------------------------------- >> drivers/vfio/pci/vfio_pci_private.h | 3 - >> drivers/vfio/virqfd.c | 214 ++++++++++++++++++++++++++++++++++++ >> include/linux/vfio.h | 28 +++++ >> 5 files changed, 245 insertions(+), 217 deletions(-) >> create mode 100644 drivers/vfio/virqfd.c -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/