Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932578AbaJaSTf (ORCPT ); Fri, 31 Oct 2014 14:19:35 -0400 Received: from p3plex2out03.prod.phx3.secureserver.net ([184.168.131.16]:46017 "EHLO p3plex2out03.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752634AbaJaSTe convert rfc822-to-8bit (ORCPT ); Fri, 31 Oct 2014 14:19:34 -0400 From: Hartley Sweeten To: Ian Abbott , "driverdev-devel@linuxdriverproject.org" CC: Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 0/5] staging: comedi: split bus support into separate modules Thread-Topic: [PATCH 0/5] staging: comedi: split bus support into separate modules Thread-Index: AQHP9TLPK/O0QzpWPkODe23bN/ro9pxKgzsQ Date: Fri, 31 Oct 2014 18:19:32 +0000 Message-ID: References: <1414777659-25578-1-git-send-email-abbotti@mev.co.uk> In-Reply-To: <1414777659-25578-1-git-send-email-abbotti@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [184.183.19.121] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, October 31, 2014 10:48 AM, Ian Abbott wrote: > The Comedi core module doesn't need support for PCI, USB or PCMCIA. > Only the low-level Comedi drivers need it. Split the support for these > bus types out of the core "comedi" module and into new modules, > "comedi_pci", "comedi_usb", and "comedi_pcmcia". > > 1) staging: comedi: comedidev.h: remove dummy PCI support functions > 2) staging: comedi: comedidev.h: remove some #ifdefs > 3) staging: comedi: split out PCMCIA support into new module > 4) staging: comedi: split out USB support into new module > 5) staging: comedi: split out PCI support into new module Ian, Is this really necessary? The pci, usb, and pcmcia support is already conditionally compiled in. The support does get added to the main comedi module instead of as separate modules but that shouldn't be a problem. Regards, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/