Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756385AbaKAFa0 (ORCPT ); Sat, 1 Nov 2014 01:30:26 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:34520 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755562AbaKAFaZ (ORCPT ); Sat, 1 Nov 2014 01:30:25 -0400 Date: Sat, 1 Nov 2014 11:00:15 +0530 From: Sudip Mukherjee To: Joe Perches Cc: Chen Weixiang , Marek Belisko , Greg Kroah-Hartman , Chen Weixiang , Aybuke Ozdemir , Felipe Balbi , Nicolas Thery , Greg Donald , Daniel Dodge , Wilfried Klaebe , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '==' Message-ID: <20141101053015.GI3642@sudip-PC> References: <1414810047-6975-1-git-send-email-weixiang.chen@gmail.com> <1414810047-6975-2-git-send-email-weixiang.chen@gmail.com> <20141101050535.GC3642@sudip-PC> <1414818870.31550.1.camel@perches.com> <20141101052501.GH3642@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141101052501.GH3642@sudip-PC> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 01, 2014 at 10:55:01AM +0530, Sudip Mukherjee wrote: > On Fri, Oct 31, 2014 at 10:14:30PM -0700, Joe Perches wrote: > > On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote: > > > On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote: > > > > Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c > > > > and ft1000/ft1000-pcmcia/ft1000_hw.c: > > > > ERROR: spaces required around that '=' (ctx:VxV) > > > > ERROR: spaces required around that '<' (ctx:VxV) > > > > ERROR: spaces required around that '==' (ctx:VxV) > > > > > > > > > > many whitespace errors in the patch. > > > checkpatch gives total: 8 errors, 23 warnings, 125 lines checked > > > > When fixing one thing (like spacing), it's pretty > > expected to have more checkpatch errors. > > > > It's a process, don't worry about most intermediate > > warnings when doing checkpatch cleanups. > > > > Adding trailing spaces is not good, nearly every > > other type of message can be ignored. > > > ok, just to verify, i thought of trying to generate a similar patch which will not give checkpatch errors. > but this patch is not applying to next-20141031. > > thanks > sudip looks like Nicky Chorley has already done part of this cleanup and it was also applied on 26/10/2014. thanks sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/