Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759975AbaKASF7 (ORCPT ); Sat, 1 Nov 2014 14:05:59 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:54659 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758469AbaKASF5 (ORCPT ); Sat, 1 Nov 2014 14:05:57 -0400 Date: Sat, 01 Nov 2014 14:05:54 -0400 (EDT) Message-Id: <20141101.140554.427928361730485371.davem@davemloft.net> To: aneesh.kumar@linux.vnet.ibm.com Cc: akpm@linux-foundation.org, steve.capper@linaro.org, aarcange@redhat.com, benh@kernel.crashing.org, mpe@ellerman.id.au, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org Subject: Re: [PATCH V4 1/2] mm: Update generic gup implementation to handle hugepage directory From: David Miller In-Reply-To: <1414570785-18966-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1414570785-18966-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Sat, 01 Nov 2014 11:05:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Aneesh Kumar K.V" Date: Wed, 29 Oct 2014 13:49:44 +0530 > +/* > + * Some architectures requires a hugepage directory format that is > + * required to support multiple hugepage sizes. For example > + * a4fe3ce7699bfe1bd88f816b55d42d8fe1dac655 introduced the same > + * on powerpc. This allows for a more flexible hugepage pagetable > + * layout. > + */ Please don't put commit IDs into the actual code. If that commit gets backported to -stable or another tree, then this comment will send someone on a wild goose chase. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/