Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751126AbaKAWYv (ORCPT ); Sat, 1 Nov 2014 18:24:51 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47655 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750712AbaKAWYt (ORCPT ); Sat, 1 Nov 2014 18:24:49 -0400 Date: Sat, 1 Nov 2014 23:24:45 +0100 From: Thomas Petazzoni To: Sudip Mukherjee Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mvpp2: fix possible memory leak Message-ID: <20141101232445.1a3fe27e@free-electrons.com> In-Reply-To: <1414841374-30537-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1414841374-30537-1-git-send-email-sudipm.mukherjee@gmail.com> Organization: Free Electrons X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Sudip Mukherjee, On Sat, 1 Nov 2014 16:59:34 +0530, Sudip Mukherjee wrote: > we are allocating memory using kzalloc for struct mvpp2_prs_entry, > but later when we are getting error we were just returning the error > value without releasing the memory. > > Signed-off-by: Sudip Mukherjee > --- > > hi, > i could not build test after modifying it. I tried to compile using > multi_v7_defconfig , but the cross compiler i have is not able to > compile it and giving sevaral warnings from the assembler. That seems weird. Which compiler are you using, and which errors were you getting? In any case, it would have been good to Cc the authors of the driver. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/