Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751115AbaKBGTd (ORCPT ); Sun, 2 Nov 2014 01:19:33 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:60071 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbaKBGTa (ORCPT ); Sun, 2 Nov 2014 01:19:30 -0500 Date: Sun, 2 Nov 2014 11:49:18 +0530 From: Sudip Mukherjee To: Thomas Petazzoni Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Marcin Wojtas Subject: Re: [PATCH] net: mvpp2: fix possible memory leak Message-ID: <20141102061918.GA2400@sudip-PC> References: <1414841374-30537-1-git-send-email-sudipm.mukherjee@gmail.com> <20141101232445.1a3fe27e@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141101232445.1a3fe27e@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 01, 2014 at 11:24:45PM +0100, Thomas Petazzoni wrote: > Dear Sudip Mukherjee, > > On Sat, 1 Nov 2014 16:59:34 +0530, Sudip Mukherjee wrote: > > we are allocating memory using kzalloc for struct mvpp2_prs_entry, > > but later when we are getting error we were just returning the error > > value without releasing the memory. > > > > Signed-off-by: Sudip Mukherjee > > --- > > > > hi, > > i could not build test after modifying it. I tried to compile using > > multi_v7_defconfig , but the cross compiler i have is not able to > > compile it and giving sevaral warnings from the assembler. > > That seems weird. Which compiler are you using, and which errors were > you getting? > > In any case, it would have been good to Cc the authors of the driver. yes, i should have. Ccing now. better late than never. i am using gcc version 4.3.2 (Sourcery G++ Lite 2008q3-72). thanks sudip > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/