Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752081AbaKCJvg (ORCPT ); Mon, 3 Nov 2014 04:51:36 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:22320 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbaKCJvO (ORCPT ); Mon, 3 Nov 2014 04:51:14 -0500 Date: Mon, 3 Nov 2014 12:50:59 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: Ursula Braun , Martin Schwidefsky , Heiko Carstens , Frank Blaschka , linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, trivial@kernel.org, Coccinelle Subject: Re: [PATCH 1/1] s390/net: Deletion of unnecessary checks before two function calls Message-ID: <20141103095059.GL6879@mwanda> References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5453C98C.90105@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5453C98C.90105@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This one is buggy. I'm sorry, but please stop sending these. For kfree(), at least we all know that kfree() accepts NULL pointer. But for this one: 1) I don't know what the functions do so I have to look at the code. 2) It's in a arch that I don't compile so cscope isn't set up meaning it's hard to find the functions. You're sending a lot of patches and they are all hard to review and some of them are buggy and none of them really add any value. It's a waste of your time and it's a waste of my time. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/