Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751947AbaKCKKo (ORCPT ); Mon, 3 Nov 2014 05:10:44 -0500 Received: from verein.lst.de ([213.95.11.211]:48332 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbaKCKKn (ORCPT ); Mon, 3 Nov 2014 05:10:43 -0500 Date: Mon, 3 Nov 2014 11:10:39 +0100 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Jens Axboe , Richard Weinberger , ceph-devel@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 2/2] blk-mq: allow direct dispatch to a driver specific workqueue Message-ID: <20141103101039.GA10128@lst.de> References: <1415003008-16683-1-git-send-email-hch@lst.de> <1415003008-16683-3-git-send-email-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 03, 2014 at 04:40:47PM +0800, Ming Lei wrote: > The above two aren't enough because the big problem is that > drivers need a per-request work structure instead of 'hctx->run_work', > otherwise there are at most NR_CPUS concurrent submissions. > > So the per-request work structure should be exposed to blk-mq > too for the kind of usage, such as .blk_mq_req_work(req) callback > in case of BLK_MQ_F_WORKQUEUE. Hmm. Maybe a better option is to just add a flag to never defer ->queue_rq to a workqueue and let drivers handle the it? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/