Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753533AbaKCRGz (ORCPT ); Mon, 3 Nov 2014 12:06:55 -0500 Received: from mail-la0-f48.google.com ([209.85.215.48]:52013 "EHLO mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbaKCRGw (ORCPT ); Mon, 3 Nov 2014 12:06:52 -0500 MIME-Version: 1.0 In-Reply-To: <20141103083447.GA8617@infradead.org> References: <4e8f7a1abcf5e0527ef8968143b2d0fcae48f5f4.1414658968.git.e@nanocritical.com> <5452B241.5010603@amacapital.net> <20141031084220.GA29085@infradead.org> <20141103083447.GA8617@infradead.org> From: Andy Lutomirski Date: Mon, 3 Nov 2014 09:06:30 -0800 Message-ID: Subject: Re: [RFC PATCH] fs: allow open(dir, O_TMPFILE|..., 0) with mode 0 To: Christoph Hellwig Cc: "linux-kernel@vger.kernel.org" , Eric Rannaud , Andrew Morton , Al Viro , Linus Torvalds , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Nov 3, 2014 12:34 AM, "Christoph Hellwig" wrote: > > On Fri, Oct 31, 2014 at 11:53:09AM -0700, Linus Torvalds wrote: > > On Fri, Oct 31, 2014 at 11:44 AM, Andy Lutomirski wrote: > > > > > > Does the patch in this thread not fix that? > > > > It should. Modulo the glibc problem that makes it hard to actually set > > the mode properly. > > That doesn't help because we explicitly reject O_RDONLY when combined > with O_TMPFILE. I think I'm missing something. How is an O_RDONLY temporary file useful? Wouldn't you want an O_RDWR tempfile with mode 0400 or something like that? --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/