Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754271AbaKCSRo (ORCPT ); Mon, 3 Nov 2014 13:17:44 -0500 Received: from mga02.intel.com ([134.134.136.20]:32480 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753644AbaKCSRm convert rfc822-to-8bit (ORCPT ); Mon, 3 Nov 2014 13:17:42 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,308,1413270000"; d="scan'208";a="601315232" From: "R, Durgadoss" To: Eduardo Valentin , Yao Dongdong CC: "Zhang, Rui" , "linux-pm@vger.kernel.org" , LKML Subject: RE: [PATCH 1/2] Thermal:Fix memory leak if occur goto unregister Thread-Topic: [PATCH 1/2] Thermal:Fix memory leak if occur goto unregister Thread-Index: AQHP7D/cSm3pVDng20+RCqIn4qhNBJw4j3QAgBa8V5A= Date: Mon, 3 Nov 2014 18:17:37 +0000 Message-ID: <4D68720C2E767A4AA6A8796D42C8EB590902F30A@BGSMSX101.gar.corp.intel.com> References: <5444C778.8050008@huawei.com> <20141020123338.GA3744@developer> In-Reply-To: <20141020123338.GA3744@developer> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >-----Original Message----- >From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- >owner@vger.kernel.org] On Behalf Of Eduardo Valentin >Sent: Monday, October 20, 2014 6:04 PM >To: Yao Dongdong >Cc: Zhang, Rui; linux-pm@vger.kernel.org; LKML >Subject: Re: [PATCH 1/2] Thermal:Fix memory leak if occur goto unregister > >Hello, > >On Mon, Oct 20, 2014 at 04:27:36PM +0800, Yao Dongdong wrote: >> Signed-off-by:yaodongdong@huawei.com > >Acked-by: Eduardo Valentin > >Rui, would you take care of this? > If I remember it right, this 'tz' is freed in the thermal_release() function, during device_unregister(). It is similar in all other functions in thermal_core.c So, Yao, Did you really test this patch ? And did not see any crashes ? Thanks, Durga >> >> --- >> drivers/thermal/thermal_core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c >> index 71b0ec0..5b7d466 100644 >> --- a/drivers/thermal/thermal_core.c >> +++ b/drivers/thermal/thermal_core.c >> @@ -1574,6 +1574,7 @@ struct thermal_zone_device >*thermal_zone_device_register(const char *type, >> unregister: >> release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id); >> device_unregister(&tz->device); >> + kfree(tz); >> return ERR_PTR(result); >> } >> EXPORT_SYMBOL_GPL(thermal_zone_device_register); >> -- >> 1.8.0.1 >> >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/