Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbaKCW0l (ORCPT ); Mon, 3 Nov 2014 17:26:41 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:37201 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbaKCW0k (ORCPT ); Mon, 3 Nov 2014 17:26:40 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 3 Nov 2014 23:26:38 +0100 X-Google-Sender-Auth: 86CeWtrdLoRju_jt4qJJAbkEUWU Message-ID: Subject: Re: bisected regression: qla2xxx endianness on sparc64 From: Geert Uytterhoeven To: Meelis Roos Cc: Joe Carnuccio , Saurav Kashyap , Christoph Hellwig , qla2xxx-upstream@qlogic.com, "James E.J. Bottomley" , scsi , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 2, 2014 at 7:10 PM, Meelis Roos wrote: > Between 3.17 and 3.18-rc2, qla2xxx is broken on my sparc64 machines. It > fails to boot (hangs in firmware rings init). > > This is the result of bisect: > > 98aee70d19a7e3203649fa2078464e4f402a0ad8 is the first bad commit > commit 98aee70d19a7e3203649fa2078464e4f402a0ad8 > Author: Joe Carnuccio > Date: Thu Sep 25 05:16:38 2014 -0400 > > qla2xxx: Add endianizer to max_payload_size modifier. > > Signed-off-by: Joe Carnuccio > Signed-off-by: Saurav Kashyap > Signed-off-by: Christoph Hellwig > > :040000 040000 041c1a26dc2a7988900acc982e3bd65d3cf7e751 > 9700d09c3226fc352d44352f22b84f1be632d324 M s > > This may not be the only problem - when bisecting, I also came to commits > that got past this step but hang after about 165 seconds of uptime while > running userspace startup scripts. But let that be another issue at the > moment. Switching from uint16_t to __le16 but _removing_ cpu_to_le16() operations looks indeed very fishy. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/