Date: Mon, 3 Nov 2014 16:13:55 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: steph <stephanie.s.wallick@intel.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        "Sean O. Stalley" <sean.stalley@intel.com>
Subject: Re: [PATCH 01/10] added media agnostic (MA) USB HCD driver
Message-ID: <20141104001355.GA10900@kroah.com>
References: <1415047377-3139-1-git-send-email-stephanie.s.wallick@intel.com>
 <1415047377-3139-2-git-send-email-stephanie.s.wallick@intel.com>
 <20141103212139.GB7379@kroah.com>
 <20141104000442.GC8890@steph-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141104000442.GC8890@steph-desktop>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org

On Mon, Nov 03, 2014 at 04:04:42PM -0800, steph wrote:
> On Mon, Nov 03, 2014 at 01:21:39PM -0800, Greg KH wrote:
> > On Mon, Nov 03, 2014 at 12:42:48PM -0800, Stephanie Wallick wrote:
> > > +EXPORT_SYMBOL(mausb_register_ms_driver);
> > 
> > EXPORT_SYMBOL_GPL()?  I have to ask...
> >
> The source is dual-licenced under BSD and GPL. It was our understanding
> that dual-licensed should use EXPORT_SYMBOL() instead. Is that wrong?

Talk to your company lawyers please to get confirmation of what you want
to do here, I can't answer this question, I just have to ask...

> > > +static int mausb_hcd_init(void)
> > > +{
> > > +	int ret;
> > > +
> > > +	/* register HCD driver */
> > > +	ret = platform_driver_register(&mausb_driver);
> > 
> > Why is this a platform driver?  How does this relate to platform
> > hardware?
> > 
> The driver doesn't require platform resources. It looks like a host
> controller driver but communicates over the network instead of to
> a physical host controller. There is no MA USB-specific hardware.
> 
> Should we use a struct device instead of a struct platform_device?

Yes, please make it a "virtual" device.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/