Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750873AbaKDBQY (ORCPT ); Mon, 3 Nov 2014 20:16:24 -0500 Received: from mail-ie0-f182.google.com ([209.85.223.182]:36625 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbaKDBQW (ORCPT ); Mon, 3 Nov 2014 20:16:22 -0500 Message-ID: <54582857.2020406@gmail.com> Date: Tue, 04 Nov 2014 09:13:59 +0800 From: hejianet User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8188eu: Fix coding style space related ERROR problems References: <1414682501-1361-1-git-send-email-hejianet@gmail.com> <1414721235-2432-1-git-send-email-hejianet@gmail.com> <20141104002557.GA19472@kroah.com> In-Reply-To: <20141104002557.GA19472@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg Sorry for the inconvience. Seems I generated the patch @ your master branch instead of staging-test. I will rebase it later. B.R. Justin On Mon, 3 Nov 2014 16:25:57 -0800 from gregkh@linuxfoundation.org wrote: > On Fri, Oct 31, 2014 at 10:07:15AM +0800, Jia He wrote: >> This fixes space related ERROR reports by checkpatch.pl >> Generated by $ git ls-files "drivers/staging/rtl8188eu/*.[ch]" | \ >> xargs ./scripts/checkpatch.pl -f --fix-inplace --strict --types=SPACING >> Already checked by text comparasion >> $git diff -w >> and binary comparasion of r8188eu.ko >> $objdiff diff >> >> Signed-off-by: Jia He > Doesn't apply to my tree at all: > > checking file drivers/staging/rtl8188eu/core/rtw_cmd.c > Hunk #1 succeeded at 637 (offset -1 lines). > checking file drivers/staging/rtl8188eu/core/rtw_ieee80211.c > checking file drivers/staging/rtl8188eu/core/rtw_mlme.c > Hunk #1 succeeded at 2115 (offset -2 lines). > checking file drivers/staging/rtl8188eu/core/rtw_mlme_ext.c > checking file drivers/staging/rtl8188eu/core/rtw_pwrctrl.c > Reversed (or previously applied) patch detected! Assume -R? [n] > Apply anyway? [n] > Skipping patch. > 1 out of 1 hunk ignored > checking file drivers/staging/rtl8188eu/core/rtw_recv.c > checking file drivers/staging/rtl8188eu/core/rtw_security.c > checking file drivers/staging/rtl8188eu/core/rtw_sta_mgt.c > checking file drivers/staging/rtl8188eu/core/rtw_xmit.c > checking file drivers/staging/rtl8188eu/hal/bb_cfg.c > Reversed (or previously applied) patch detected! Assume -R? [n] > Apply anyway? [n] > Skipping patch. > 2 out of 2 hunks ignored > checking file drivers/staging/rtl8188eu/hal/fw.c > checking file drivers/staging/rtl8188eu/hal/mac_cfg.c > checking file drivers/staging/rtl8188eu/hal/odm.c > checking file drivers/staging/rtl8188eu/hal/odm_HWConfig.c > checking file drivers/staging/rtl8188eu/hal/odm_RTL8188E.c > checking file drivers/staging/rtl8188eu/hal/phy.c > checking file drivers/staging/rtl8188eu/hal/rf.c > checking file drivers/staging/rtl8188eu/hal/rf_cfg.c > checking file drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c > Hunk #1 succeeded at 252 (offset -2 lines). > checking file drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c > checking file drivers/staging/rtl8188eu/hal/usb_halinit.c > checking file drivers/staging/rtl8188eu/include/ieee80211_ext.h > checking file drivers/staging/rtl8188eu/include/odm_debug.h > Hunk #1 FAILED at 125. > 1 out of 1 hunk FAILED > checking file drivers/staging/rtl8188eu/include/osdep_service.h > checking file drivers/staging/rtl8188eu/include/rtw_debug.h > checking file drivers/staging/rtl8188eu/include/rtw_led.h > checking file drivers/staging/rtl8188eu/include/rtw_mlme_ext.h > checking file drivers/staging/rtl8188eu/include/wifi.h > checking file drivers/staging/rtl8188eu/os_dep/ioctl_linux.c > checking file drivers/staging/rtl8188eu/os_dep/os_intfs.c > checking file drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c > checking file drivers/staging/rtl8188eu/os_dep/xmit_linux.c > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/