Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751855AbaKDDLH (ORCPT ); Mon, 3 Nov 2014 22:11:07 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:12311 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbaKDDLE (ORCPT ); Mon, 3 Nov 2014 22:11:04 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 03 Nov 2014 19:05:25 -0800 Message-ID: <545843B1.3020101@nvidia.com> Date: Tue, 4 Nov 2014 12:10:41 +0900 From: Alexandre Courbot Organization: NVIDIA User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Mika Westerberg , "Rafael J. Wysocki" CC: Linus Walleij , Bryan Wu , Richard Purdie , Ben Dooks , Kukjin Kim , Jason Cooper , Andrew Lunn , , , Subject: Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors References: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com> In-Reply-To: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com> X-NVConfidentiality: public X-Originating-IP: [10.19.57.128] X-ClientProxiedBy: HKMAIL101.nvidia.com (10.18.16.10) To HKMAIL102.nvidia.com (10.18.16.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/2014 08:40 PM, Mika Westerberg wrote: > Commit 21f2aae91e902aad ("leds: leds-gpio: Add support for GPIO > descriptors") already converted most of the driver to use GPIO descriptors. > What is still missing is the platform specific hook gpio_blink_set() and > board files which pass legacy GPIO numbers to this driver in platform data. > > In this patch we handle the former and convert gpio_blink_set() to take > GPIO descriptor instead. In order to do this we convert the existing four > users to accept GPIO descriptor and translate it to legacy GPIO number in > the platform code. This effectively "pushes" legacy GPIO number usage from > the driver to platforms. > > Also add comment to the remaining block describing that it is legacy code > path and we are getting rid of it eventually. > > Suggested-by: Linus Walleij > Signed-off-by: Mika Westerberg Acked-by: Alexandre Courbot -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/