Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752777AbaKDJYx (ORCPT ); Tue, 4 Nov 2014 04:24:53 -0500 Received: from mail7.hitachi.co.jp ([133.145.228.42]:46086 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752454AbaKDJYs (ORCPT ); Tue, 4 Nov 2014 04:24:48 -0500 Message-ID: <54589B58.7080102@hitachi.com> Date: Tue, 04 Nov 2014 18:24:40 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Pawel Moll Cc: Richard Cochran , Steven Rostedt , Ingo Molnar , Peter Zijlstra , Paul Mackerras , Arnaldo Carvalho de Melo , John Stultz , Christopher Covington , Namhyung Kim , David Ahern , Thomas Gleixner , Tomeu Vizoso , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Pawel Moll Subject: Re: [PATCH v3 0/3] perf: User/kernel time correlation and event generation References: <1415060918-19954-1-git-send-email-pawel.moll@arm.com> In-Reply-To: <1415060918-19954-1-git-send-email-pawel.moll@arm.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, (2014/11/04 9:28), Pawel Moll wrote: > 2. User event generation > > Everyone present agreed that it would be a very-nice-to-have feature. > There was some discussion about implementation details, so I welcome > feedback and comments regarding my take on the matter. Hmm, I'm trying to make a similar thing, dynamic event definition via ftrace, which is already done by kprobes/uprobes. And this will be shown as dynamic events from perf too. What I'd like to do is the binary version of ftrace-marker, the text version is already supported by qemu (see below). https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg00505.html But since that is just a string data (not structured data), it is hard to analyze via perf-script or some other useful filters/triggers in ftrace. In my idea, the new event will be defined via a special file in debugfs like kprobe-events, like below. # cd $debugfs/tracing # echo "newgrp/newevent signarg:s32 flag:u64" >> marker_events # cat events/newgrp/newevent/format name: newevent ID: 2048 format: field:unsigned short common_type; offset:0; size:2; signed:0; field:unsigned char common_flags; offset:2; size:1; signed:0; field:unsigned char common_preempt_count; offset:3; size:1;signed:0; field:int common_pid; offset:4; size:4; signed:1; field:s32 signarg; offset:8; size:4; signed:1; field:u64 flag; offset:12; size:8; signed:0; print fmt: "signarg=%d flag=0x%Lx", REC->signarg, REC->flag Then, users will write the data (excluded common fields) when the event happens via trace_marker which start with '\0'ID(in u32). Kernel just checks the ID and its data size, but doesn't parse, filter/trigger it and log it into the kernel buffer. Of course, this has a downside that the user must have a privilege to access to debugfs. Thus maybe we need both of prctl() IF for perf and this IF for ftrace. Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/