Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752358AbaKDJhW (ORCPT ); Tue, 4 Nov 2014 04:37:22 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:60402 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985AbaKDJhS (ORCPT ); Tue, 4 Nov 2014 04:37:18 -0500 Date: Tue, 4 Nov 2014 15:06:53 +0530 From: Sudip Mukherjee To: Aya Mahfouz Cc: Jarod Wilson , Mauro Carvalho Chehab , Greg Kroah-Hartman , Dan Carpenter , Gulsah Kose , Tuomas Tynkkynen , Matina Maria Trompouki , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: lirc: replace dev_err by pr_err Message-ID: <20141104093653.GA3070@sudip-PC> References: <20141104001319.GA14567@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141104001319.GA14567@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote: > This patch replaces dev_err by pr_err since the value > of ir is NULL when the message is displayed. > > Signed-off-by: Aya Mahfouz > --- > drivers/staging/media/lirc/lirc_zilog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c > index 11a7cb1..ecdd71e 100644 > --- a/drivers/staging/media/lirc/lirc_zilog.c > +++ b/drivers/staging/media/lirc/lirc_zilog.c > @@ -1633,7 +1633,7 @@ out_put_xx: > out_put_ir: > put_ir_device(ir, true); > out_no_ir: > - dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n", > + pr_err("%s: probing IR %s on %s (i2c-%d) failed with %d\n", hi, instead of ir->l.dev , can you please try dev_err like this : dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n", __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr, ret); thanks sudip > __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr, > ret); > mutex_unlock(&ir_devices_lock); > -- > 1.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/