Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752896AbaKDKPA (ORCPT ); Tue, 4 Nov 2014 05:15:00 -0500 Received: from s3.sipsolutions.net ([5.9.151.49]:52671 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbaKDKO5 (ORCPT ); Tue, 4 Nov 2014 05:14:57 -0500 Message-ID: <1415096092.2064.13.camel@sipsolutions.net> Subject: Re: [PATCH v1 10/11] backports: prefix c-file / h-file auto backport with BPAUTO From: Johannes Berg To: "Luis R. Rodriguez" Cc: backports@vger.kernel.org, linux-kernel@vger.kernel.org, yann.morin.1998@free.fr, mmarek@suse.cz, sassmann@kpanic.de, "Luis R. Rodriguez" Date: Tue, 04 Nov 2014 11:14:52 +0100 In-Reply-To: <1415090582-14129-11-git-send-email-mcgrof@do-not-panic.com> (sfid-20141104_094716_255472_7B15EC6D) References: <1415090582-14129-1-git-send-email-mcgrof@do-not-panic.com> <1415090582-14129-11-git-send-email-mcgrof@do-not-panic.com> (sfid-20141104_094716_255472_7B15EC6D) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.7-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-11-04 at 00:43 -0800, Luis R. Rodriguez wrote: > - mf.write('compat-$(%s%s) += %s\n' % (bp_prefix, sym, ' '.join(o_files))) > + if bp_prefix not in sym: > + mf.write('compat-$(%s%s) += %s\n' % (bp_prefix, sym, ' '.join(o_files))) > + else: > + mf.write('compat-$(%s) += %s\n' % (sym, ' '.join(o_files))) I don't think these changes are correct, the bp_prefix is needed anyway, and there's no way it could already be. Looks like this comes from a previous attempt where you misunderstood and thought CONFIG_BACKPORT_BACKPORT_... was actually wrong, when in fact it is correct (and would now be CONFIG_BACKPORT_BPAUTO_...) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/