Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559AbaKDKn3 (ORCPT ); Tue, 4 Nov 2014 05:43:29 -0500 Received: from exprod7og108.obsmtp.com ([64.18.2.169]:43902 "EHLO exprod7og108.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750804AbaKDKnZ (ORCPT ); Tue, 4 Nov 2014 05:43:25 -0500 X-Greylist: delayed 438 seconds by postgrey-1.27 at vger.kernel.org; Tue, 04 Nov 2014 05:43:25 EST From: Sumit Saxena References: <1415018660-30775-1-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1415018660-30775-1-git-send-email-jiang.liu@linux.intel.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQFrfRpytSGaF/4nkIvrxKUESb0pIZ0ZO/PA Date: Tue, 4 Nov 2014 16:06:06 +0530 Message-ID: Subject: RE: [PATCH] megaraid_sas : Fix bug in handling return value of pci_enable_msix_range() To: Jiang Liu , Neela Syam Kolli , "James E.J. Bottomley" Cc: Alexander Gordeev , linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >-----Original Message----- >From: Jiang Liu [mailto:jiang.liu@linux.intel.com] >Sent: Monday, November 03, 2014 6:14 PM >To: Neela Syam Kolli; James E.J. Bottomley >Cc: Jiang Liu; Alexander Gordeev; linux-pci@vger.kernel.org; linux- >scsi@vger.kernel.org; linux-kernel@vger.kernel.org >Subject: [PATCH] megaraid_sas : Fix bug in handling return value of >pci_enable_msix_range() > >Function pci_enable_msix_range() may return negative values for error >conditions. So it's a bug by checking (pci_enable_msix_range() != 0) for >success and causes failure to megaraid driver when MSI is disabled. >[ 16.487267] megaraid_sas 0000:02:00.0: Controller type: iMR >[ 16.487275] genirq: Flags mismatch irq 0. 00000000 (megasas) vs. 00015a00 (tii >mer) >[ 16.487347] megasas: Failed to register IRQ for vector 0. > >Fixes: 8ae80ed1734b "megaraid: Use pci_enable_msix_range() instead of >pci_enable_msix()" > >Signed-off-by: Jiang Liu >Cc: Alexander Gordeev >Cc: "Bjorn Helgaas " >Cc: linux-pci@vger.kernel.org >Cc: # 3.17 >--- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >b/drivers/scsi/megaraid/megaraid_sas_base.c >index f6a69a3b1b3f..5640ad1c8214 100644 >--- a/drivers/scsi/megaraid/megaraid_sas_base.c >+++ b/drivers/scsi/megaraid/megaraid_sas_base.c >@@ -4453,7 +4453,7 @@ static int megasas_init_fw(struct megasas_instance >*instance) > instance->msixentry[i].entry = i; > i = pci_enable_msix_range(instance->pdev, instance- >>msixentry, > 1, instance->msix_vectors); >- if (i) >+ if (i > 0) > instance->msix_vectors = i; > else > instance->msix_vectors = 0; Acked-by: Sumit Saxena >-- >1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/