Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253AbaKDOnL (ORCPT ); Tue, 4 Nov 2014 09:43:11 -0500 Received: from helcar.apana.org.au ([209.40.204.226]:51526 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753923AbaKDOnI (ORCPT ); Tue, 4 Nov 2014 09:43:08 -0500 Date: Tue, 4 Nov 2014 22:42:58 +0800 From: Herbert Xu To: Al Viro Cc: "David S. Miller" , netdev@vger.kernel.org, Linux Kernel Mailing List , Benjamin LaHaise Subject: Re: [PATCH 1/4] inet: Add skb_copy_datagram_iter Message-ID: <20141104144258.GA14743@gondor.apana.org.au> References: <20141104033818.GA11149@gondor.apana.org.au> <20141104143200.GC7996@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141104143200.GC7996@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 04, 2014 at 02:32:00PM +0000, Al Viro wrote: > > Too noisy, IMO. How about skb_copy_datagram_msg() first? The fewer > places have to even think of iovec or iov_iter, the better... We have places like tcp ucopy and tun that do not have msghdr. So doing skb_copy_datagram_msg means that we'd have to create a fake msghdr wrapper around them. The point is not everything comes in via sendmsg/recvmsg. What is your motivation for hiding iov/iov_iter? Do you plan to change their API at some future point? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/