Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754570AbaKDP6W (ORCPT ); Tue, 4 Nov 2014 10:58:22 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:52252 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753875AbaKDP6U (ORCPT ); Tue, 4 Nov 2014 10:58:20 -0500 From: "Rafael J. Wysocki" To: Grant Likely Cc: Mika Westerberg , Linux Kernel Mailing List , ACPI Devel Maling List , Greg Kroah-Hartman , Darren Hart , Aaron Lu , Arnd Bergmann , "devicetree@vger.kernel.org" , Linus Walleij , Alexandre Courbot , Dmitry Torokhov , Bryan Wu Subject: Re: [PATCH v6 04/12] misc: at25: Make use of device property API Date: Tue, 04 Nov 2014 17:19:02 +0100 Message-ID: <4645043.WOkgNMSUuO@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <13750506.S2yVlRRDa2@vostro.rjw.lan> <20141104143801.GM1618@lahna.fi.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, November 04, 2014 03:04:54 PM Grant Likely wrote: > On Tue, Nov 4, 2014 at 2:38 PM, Mika Westerberg > wrote: > > On Tue, Nov 04, 2014 at 02:18:26PM +0000, Grant Likely wrote: > >> > - strncpy(chip->name, np->name, sizeof(chip->name)); > >> > + strncpy(chip->name, "at25", sizeof(chip->name)); > >> > >> This line changes behaviour of the driver. It's possibly not a problem, > >> but it should be commented on and whether any due diligance has been > >> done to make sure it there isn't anything that depends on it. > > > > I found only one user for "atmel,at25" in any of the DT sample files. > > > > arch/arm/boot/dts/phy3250.dts: > > > > eeprom: at25@0 { > > ... > > at25,byte-len = <0x8000>; > > at25,addr-mode = <2>; > > at25,page-size = <64>; > > > > compatible = "atmel,at25"; > > reg = <0>; > > spi-max-frequency = <5000000>; > > }; > > > > I think np->name is "at25" in this case? The binding file > > Documentation/devicetree/bindings/misc/at25.txt also has the same name. > > > > Are you OK, if we add something like below to the changelog? > > > > In addition we hard-code the name of the chip to be "at25" for the > > reason that there is no common mechanism to fetch name of the firmware > > node. The only existing user (arch/arm/boot/dts/phy3250.dts) uses the > > same name so it should continue to work. > > Yes. If somebody complains, then we can reinstate the previous > behaviour, but assume it isn't necessary for now. OK, done in my tree. I've added the ACK too, but that still is in my bleeding-edge branch for now until it gets build tested and I can pull http://marc.info/?l=linux-kernel&m=141505792126265&w=4 from somewhere. :-) Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/