Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754656AbaKDQHt (ORCPT ); Tue, 4 Nov 2014 11:07:49 -0500 Received: from mga11.intel.com ([192.55.52.93]:27680 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbaKDQHp (ORCPT ); Tue, 4 Nov 2014 11:07:45 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="411236371" Date: Tue, 4 Nov 2014 18:07:35 +0200 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: Grant Likely , Linux Kernel Mailing List , ACPI Devel Maling List , Greg Kroah-Hartman , Darren Hart , Aaron Lu , Arnd Bergmann , "devicetree@vger.kernel.org" , Linus Walleij , Alexandre Courbot , Dmitry Torokhov , Bryan Wu Subject: Re: [PATCH v6 04/12] misc: at25: Make use of device property API Message-ID: <20141104160735.GO1618@lahna.fi.intel.com> References: <13750506.S2yVlRRDa2@vostro.rjw.lan> <20141104143801.GM1618@lahna.fi.intel.com> <4645043.WOkgNMSUuO@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4645043.WOkgNMSUuO@vostro.rjw.lan> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 04, 2014 at 05:19:02PM +0100, Rafael J. Wysocki wrote: > > > I think np->name is "at25" in this case? The binding file > > > Documentation/devicetree/bindings/misc/at25.txt also has the same name. > > > > > > Are you OK, if we add something like below to the changelog? > > > > > > In addition we hard-code the name of the chip to be "at25" for the > > > reason that there is no common mechanism to fetch name of the firmware > > > node. The only existing user (arch/arm/boot/dts/phy3250.dts) uses the > > > same name so it should continue to work. > > > > Yes. If somebody complains, then we can reinstate the previous > > behaviour, but assume it isn't necessary for now. > > OK, done in my tree. Thanks Rafael! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/