Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751861AbaKDRB2 (ORCPT ); Tue, 4 Nov 2014 12:01:28 -0500 Received: from mail-ig0-f180.google.com ([209.85.213.180]:51834 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751747AbaKDRBZ (ORCPT ); Tue, 4 Nov 2014 12:01:25 -0500 MIME-Version: 1.0 In-Reply-To: <3645687.BsyGDrJDrU@vostro.rjw.lan> References: <13750506.S2yVlRRDa2@vostro.rjw.lan> <2127128.VT1Iq03xz1@vostro.rjw.lan> <3645687.BsyGDrJDrU@vostro.rjw.lan> From: Grant Likely Date: Tue, 4 Nov 2014 17:01:04 +0000 X-Google-Sender-Auth: -F5YKZYifk7oj-24Gvzwxwt3ANg Message-ID: Subject: Re: [PATCH v6 02/12] Driver core: Unified device properties interface for platform firmware To: "Rafael J. Wysocki" Cc: Linux Kernel Mailing List , Arnd Bergmann , ACPI Devel Maling List , Greg Kroah-Hartman , Darren Hart , Mika Westerberg , Aaron Lu , "devicetree@vger.kernel.org" , Linus Walleij , Alexandre Courbot , Dmitry Torokhov , Bryan Wu Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 3, 2014 at 10:04 PM, Rafael J. Wysocki wrote: >> I also found that this parser code doesn't correctly handle malformed >> (unterminated) string properties. It will overflow. The existing >> functions have the same problem, so it isn't something that you've >> added. I've got a fix, and as a side effect the fix creates the _array >> version basically for free as part of reworking >> of_property_count_strings() and of_property_read_string_index() > > OK > > So can you please point me to a git branch containing the fix? I'll rebase the > patch on top of that then and everything should merge just fine. git://git.kernel.org/pub/scm/linux/kernel/git/glikely/linux.git devicetree/merge I'm going to let the patch sit in there for a few days to get linux-next exposure before I ask Linus to pull. The pull req will go out before the end of the week. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/