Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752091AbaKDRER (ORCPT ); Tue, 4 Nov 2014 12:04:17 -0500 Received: from mail-qc0-f177.google.com ([209.85.216.177]:40116 "EHLO mail-qc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751129AbaKDREO (ORCPT ); Tue, 4 Nov 2014 12:04:14 -0500 MIME-Version: 1.0 In-Reply-To: <20141104162054.4CC9BC423D0@trevor.secretlab.ca> References: <1414497065-9808-1-git-send-email-thunder.leizhen@huawei.com> <20141104162054.4CC9BC423D0@trevor.secretlab.ca> From: Bjorn Helgaas Date: Tue, 4 Nov 2014 10:03:52 -0700 Message-ID: Subject: Re: [PATCH 1/1] of/fdt: simplify early_init_dt_verify To: Grant Likely Cc: Zhen Lei , Rob Herring , devicetree , linux-kernel , Zefan Li , Xinwei Hu , Kefeng Wang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 4, 2014 at 9:20 AM, Grant Likely wrote: > On Tue, 28 Oct 2014 19:51:05 +0800 > , Zhen Lei > wrote: >> put off initial_boot_params = params; until all checks finished. If any check >> failed, initial_boot_params is equal NULL, base upon bss segment initial value. >> >> Signed-off-by: Zhen Lei > > Interesting. I received exactly the same patch from Bjorn Helgaas. Were > the two of you working together, or is this merely a coincedence? LOL, that's really funny. We're not working together, so it's a total coincidence :) >> --- >> drivers/of/fdt.c | 10 ++++------ >> 1 file changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c >> index d1ffca8..325c638 100644 >> --- a/drivers/of/fdt.c >> +++ b/drivers/of/fdt.c >> @@ -994,14 +994,12 @@ bool __init early_init_dt_verify(void *params) >> if (!params) >> return false; >> >> - /* Setup flat device-tree pointer */ >> - initial_boot_params = params; >> - >> /* check device tree validity */ >> - if (fdt_check_header(params)) { >> - initial_boot_params = NULL; >> + if (fdt_check_header(params)) >> return false; >> - } >> + >> + /* Setup flat device-tree pointer */ >> + initial_boot_params = params; >> >> return true; >> } >> -- >> 1.8.0 >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/