Date: Tue, 4 Nov 2014 14:32:49 -0500
From: Jonathan Corbet <corbet@lwn.net>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/1 net-next] ipv4: add kernel parameter
 tcpmhash_entries
Message-ID: <20141104143249.608c9fe4@lwn.net>
In-Reply-To: <1415128988-11665-1-git-send-email-fabf@skynet.be>
References: <1415128988-11665-1-git-send-email-fabf@skynet.be>
Organization: LWN.net
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue,  4 Nov 2014 20:23:08 +0100
Fabian Frederick <fabf@skynet.be> wrote:

> +			Set tcp_metrics_hash slot number.

So I'm not entirely clear on what that means.  Did you mean "Set the
number of tcp_metrics_hash slots"?  If so, that wording should be used.

Even in that case, though, what does this parameter actually *mean*?  If
we're going to document the parameter (and I think we should), it would
be good to say why a user might want to change it and what effects they
would expect to see.

Care to redo with that in mind?

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/