Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753035AbaKDXxW (ORCPT ); Tue, 4 Nov 2014 18:53:22 -0500 Received: from na6sys009bog024.obsmtp.com ([74.125.150.88]:39426 "HELO na6sys009bog024.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752696AbaKDXxT (ORCPT ); Tue, 4 Nov 2014 18:53:19 -0500 X-Greylist: delayed 455 seconds by postgrey-1.27 at vger.kernel.org; Tue, 04 Nov 2014 18:53:19 EST MIME-Version: 1.0 In-Reply-To: <1415138202-1197-3-git-send-email-joestringer@nicira.com> References: <1415138202-1197-1-git-send-email-joestringer@nicira.com> <1415138202-1197-3-git-send-email-joestringer@nicira.com> From: Jesse Gross Date: Tue, 4 Nov 2014 15:45:22 -0800 Message-ID: Subject: Re: [PATCH net 2/5] i40e: Implement ndo_gso_check() To: Joe Stringer Cc: netdev , Sathya Perla , Jeff Kirsher , linux.nics@intel.com, amirv@mellanox.com, shahed.shaikh@qlogic.com, Dept-GELinuxNICDev@qlogic.com, Tom Herbert , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 4, 2014 at 1:56 PM, Joe Stringer wrote: > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c > index c3a7f4a..21829b5 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > +static bool i40e_gso_check(struct sk_buff *skb, struct net_device *dev) > +{ > + if ((skb_shinfo(skb)->gso_type & SKB_GSO_UDP_TUNNEL) && > + (skb->inner_protocol_type != ENCAP_TYPE_ETHER || > + skb->inner_protocol != htons(ETH_P_TEB) || > + skb_inner_mac_header(skb) - skb_transport_header(skb) > 64)) > + return false; I think it may be possible to even support a few more things here. According to the datasheet here: http://www.intel.com/content/dam/www/public/us/en/documents/datasheets/xl710-10-40-controller-datasheet.pdf This can actually support 64 bytes beyond the tunnel header, which would make for a total of 80 bytes. It looks like it can also support IPv4 or IPv6 beyond just Ethernet as the encapsulated protocol. Intel guys, can you confirm that this is correct? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/